'Re: Review Request 108701: Find libgfortran if it's installed in custom prefixes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 108701: Find libgfortran if it's installed in custom prefixes
From:       "Commit Hook" <null () kde ! org>
Date:       2013-02-07 22:07:57
Message-ID: 20130207220757.12270.80554 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108701/#review26915
-----------------------------------------------------------

This review has been submitted with commit aee382880f4f7a3b8d02bf0b697e6b334eacf65a \
by Christophe Giboudeaux to branch KDE/4.10.

- Commit Hook

On Feb. 6, 2013, 10:40 p.m., Christophe Giboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108701/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 10:40 p.m.)
> 
> 
> Review request for Build System, KDE Edu and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> FindR.cmake tries to find libgfortran when the R_lapack library is found. With the \
> current file, the detection fails on openSUSE. libgfortran is not installed in a \
> common directory but in /usr/lib64/gcc/<arch>/<compiler version>/ 
> With this patch, FindR tries to find the gfortran executable and runs 'gfortran \
> -print-file-name=libgfortran.so' to get the library path. 
> if the gfortran executable cannot be found, find_library(...) is used.
> 
> 
> This addresses bug 314253.
> http://bugs.kde.org/show_bug.cgi?id=314253
> 
> 
> Diffs
> -----
> 
> cmake/FindR.cmake 11f4aff 
> 
> Diff: http://git.reviewboard.kde.org/r/108701/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with the 4.10 tarball.
> 
> 
> Thanks,
> 
> Christophe Giboudeaux
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108701/">http://git.reviewboard.kde.org/r/108701/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit aee382880f4f7a3b8d02bf0b697e6b334eacf65a by Christophe \
Giboudeaux to branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 6th, 2013, 10:40 p.m. UTC, Christophe Giboudeaux wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Build System, KDE Edu and Albert Astals Cid.</div>
<div>By Christophe Giboudeaux.</div>

<p style="color: grey;"><i>Updated Feb. 6, 2013, 10:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FindR.cmake tries to find libgfortran when the R_lapack library is \
found. With the current file, the detection fails on openSUSE. libgfortran is not \
installed in a common directory but in /usr/lib64/gcc/&lt;arch&gt;/&lt;compiler \
version&gt;/

With this patch, FindR tries to find the gfortran executable and runs &#39;gfortran \
-print-file-name=libgfortran.so&#39; to get the library path.

if the gfortran executable cannot be found, find_library(...) is used.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested successfully with the 4.10 tarball.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314253">314253</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/FindR.cmake <span style="color: grey">(11f4aff)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108701/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 