[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 108071: Krazy fixes: mark single argument constructors as explicit #2
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-02-06 23:16:56
Message-ID: 20130206231656.8487.57146 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108071/#review26806
-----------------------------------------------------------
Has this been committed? It has Ship It! but still shows open in reviewboard.
- Albert Astals Cid
On Jan. 1, 2013, 8:29 p.m., Kyle Morris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108071/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2013, 8:29 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> Add explicit keyword to constructors which could potentially lead to implicit type conversions
>
>
> Diffs
> -----
>
> src/lib/AbstractDataPlugin.h 37ab921
> src/lib/DownloadRegion.h bf6d67b
> src/lib/GeoGraphicsScene.h aa5baef
> src/lib/MarbleWidgetInputHandler.h 6c216fb
> src/lib/SearchInputWidget.h c2274e7
> src/lib/ServerLayout.h 63fbdb4
> src/lib/StoragePolicy.h 1647129
> src/lib/geodata/data/GeoDataAccuracy.h 6e7132c
> src/lib/geodata/data/GeoDataFeature.h a70e53d
> src/lib/geodata/data/GeoDataGeometry.h e5602ab
> src/lib/geodata/data/GeoDataLatLonAltBox.h bb68329
> src/lib/geodata/data/GeoDataLinearRing.h 9cfce6d
> src/lib/geodata/data/GeoDataPolygon.h 788f19e
> src/lib/geodata/data/GeoDataPolygon_p.h 46d3066
> src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h 3b4bf7e
> src/lib/geodata/graphicsitem/GeoPolygonGraphicsItem.h 3b26f0e
> src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h c320a78
> src/lib/geodata/graphicsitem/ScreenOverlayGraphicsItem.h 7cfdaac
> src/lib/geodata/scene/GeoSceneGeodata.h 9468061
> src/lib/geodata/writers/kml/KmlColorStyleTagWriter.h e9ac41c
> src/lib/geodata/writers/kml/KmlOverlayTagWriter.h e6332f2
> src/lib/graphicsview/FrameGraphicsItem_p.h 48a0524
> src/lib/graphicsview/LabelGraphicsItem_p.h feae56b
> src/lib/layers/GeometryLayer.h f89870e
> src/lib/layers/VectorMapBaseLayer.h 7db584e
> src/plugins/declarative/MapThemeModel.h e15e67e
> src/plugins/declarative/MarbleDeclarativeObject.h 721eb6c
>
> Diff: http://git.reviewboard.kde.org/r/108071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kyle Morris
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108071/">http://git.reviewboard.kde.org/r/108071/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been committed? \
It has Ship It! but still shows open in reviewboard.</pre> <br />
<p>- Albert</p>
<br />
<p>On January 1st, 2013, 8:29 p.m. UTC, Kyle Morris wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Kyle Morris.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add explicit keyword to constructors which could potentially lead to \
implicit type conversions</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractDataPlugin.h <span style="color: grey">(37ab921)</span></li>
<li>src/lib/DownloadRegion.h <span style="color: grey">(bf6d67b)</span></li>
<li>src/lib/GeoGraphicsScene.h <span style="color: grey">(aa5baef)</span></li>
<li>src/lib/MarbleWidgetInputHandler.h <span style="color: \
grey">(6c216fb)</span></li>
<li>src/lib/SearchInputWidget.h <span style="color: grey">(c2274e7)</span></li>
<li>src/lib/ServerLayout.h <span style="color: grey">(63fbdb4)</span></li>
<li>src/lib/StoragePolicy.h <span style="color: grey">(1647129)</span></li>
<li>src/lib/geodata/data/GeoDataAccuracy.h <span style="color: \
grey">(6e7132c)</span></li>
<li>src/lib/geodata/data/GeoDataFeature.h <span style="color: \
grey">(a70e53d)</span></li>
<li>src/lib/geodata/data/GeoDataGeometry.h <span style="color: \
grey">(e5602ab)</span></li>
<li>src/lib/geodata/data/GeoDataLatLonAltBox.h <span style="color: \
grey">(bb68329)</span></li>
<li>src/lib/geodata/data/GeoDataLinearRing.h <span style="color: \
grey">(9cfce6d)</span></li>
<li>src/lib/geodata/data/GeoDataPolygon.h <span style="color: \
grey">(788f19e)</span></li>
<li>src/lib/geodata/data/GeoDataPolygon_p.h <span style="color: \
grey">(46d3066)</span></li>
<li>src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h <span style="color: \
grey">(3b4bf7e)</span></li>
<li>src/lib/geodata/graphicsitem/GeoPolygonGraphicsItem.h <span style="color: \
grey">(3b26f0e)</span></li>
<li>src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h <span style="color: \
grey">(c320a78)</span></li>
<li>src/lib/geodata/graphicsitem/ScreenOverlayGraphicsItem.h <span style="color: \
grey">(7cfdaac)</span></li>
<li>src/lib/geodata/scene/GeoSceneGeodata.h <span style="color: \
grey">(9468061)</span></li>
<li>src/lib/geodata/writers/kml/KmlColorStyleTagWriter.h <span style="color: \
grey">(e9ac41c)</span></li>
<li>src/lib/geodata/writers/kml/KmlOverlayTagWriter.h <span style="color: \
grey">(e6332f2)</span></li>
<li>src/lib/graphicsview/FrameGraphicsItem_p.h <span style="color: \
grey">(48a0524)</span></li>
<li>src/lib/graphicsview/LabelGraphicsItem_p.h <span style="color: \
grey">(feae56b)</span></li>
<li>src/lib/layers/GeometryLayer.h <span style="color: grey">(f89870e)</span></li>
<li>src/lib/layers/VectorMapBaseLayer.h <span style="color: \
grey">(7db584e)</span></li>
<li>src/plugins/declarative/MapThemeModel.h <span style="color: \
grey">(e15e67e)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeObject.h <span style="color: \
grey">(721eb6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108071/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic