'Re: Review Request 108568: Set minimum size for Molar Mass Calculator widget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 108568: Set minimum size for Molar Mass Calculator widget
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-27 21:27:24
Message-ID: 20130127212724.26922.34847 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108568/#review26286
-----------------------------------------------------------

This review has been submitted with commit 865c7faf8eba951e8643fba5e433246cc3a47fa0 \
by Albert Astals Cid on behalf of Dario Cambié to branch KDE/4.10.

- Commit Hook

On Jan. 23, 2013, 9:25 p.m., Dario Cambié wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108568/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 9:25 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Description
> -------
> 
> Add setMinimumSize() to prevent periodic table's collapse
> 
> 
> This addresses bug 301859.
> http://bugs.kde.org/show_bug.cgi?id=301859
> 
> 
> Diffs
> -----
> 
> plasmoid/applet/psePlasmoid/Molmasscalculator.cpp 29db889 
> 
> Diff: http://git.reviewboard.kde.org/r/108568/diff/
> 
> 
> Testing
> -------
> 
> Compiled, on plasma restart works as expected.
> 
> 
> File Attachments
> ----------------
> 
> Patch as git-patch format
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/0001-Set-MolmassCalculator-minimum-sizeBUG-301859.patch
>  
> 
> Thanks,
> 
> Dario Cambié
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108568/">http://git.reviewboard.kde.org/r/108568/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 865c7faf8eba951e8643fba5e433246cc3a47fa0 by Albert Astals Cid \
on behalf of Dario Cambié to branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 23rd, 2013, 9:25 p.m. UTC, Dario Cambié wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Etienne Rebetez.</div>
<div>By Dario Cambié.</div>

<p style="color: grey;"><i>Updated Jan. 23, 2013, 9:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add setMinimumSize() to prevent periodic table&#39;s collapse</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, on plasma restart works as expected.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=301859">301859</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmoid/applet/psePlasmoid/Molmasscalculator.cpp <span style="color: \
grey">(29db889)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108568/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/0001-Set-MolmassCalculator-minimum-sizeBUG-301859.patch">Patch \
as git-patch format</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 