'Re: Review Request 108184: Fixing Krazy code checker issues'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 108184: Fixing Krazy code checker issues
From:       "Mayank Madan" <maddiemadan () gmail ! com>
Date:       2013-01-16 8:12:28
Message-ID: 20130116081228.5961.86632 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108184/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 8:12 a.m.)

Review request for KDE Edu and Kevin Krammer.

Changes
-------

some minor changes

Description
-------

http://www.google-melange.com/gci/task/view/google/gci2012/8193206

Diffs (updated)
-----

  kstars/ekos/guide/gmath.cpp bf629a2 
  kstars/ekos/guide/guider.cpp 30c6bcd 
  kstars/ekos/guide/rcalibration.cpp 3340ae4 
  kstars/ekos/guide/scroll_graph.cpp a37e81c 
  kstars/fitsviewer/fitsviewer.cpp d5c3fcb 
  kstars/printing/pwizfovsh.cpp b5a4101 
  kstars/printing/pwizobjectselection.cpp 50b9f5a 
  kstars/skyobjects/satellite.cpp 0ca44f7 
  kstars/tools/conjunctions.cpp 6b8c081 
  kstars/tools/modcalcvlsr.cpp 2a9b355 

Diff: http://git.reviewboard.kde.org/r/108184/diff/

Testing
-------

Yes, compiled and tested

Thanks,

Mayank Madan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108184/">http://git.reviewboard.kde.org/r/108184/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2013, 8:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">some minor changes</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8193206</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, compiled and tested</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/ekos/guide/gmath.cpp <span style="color: grey">(bf629a2)</span></li>

 <li>kstars/ekos/guide/guider.cpp <span style="color: grey">(30c6bcd)</span></li>

 <li>kstars/ekos/guide/rcalibration.cpp <span style="color: \
grey">(3340ae4)</span></li>

 <li>kstars/ekos/guide/scroll_graph.cpp <span style="color: \
grey">(a37e81c)</span></li>

 <li>kstars/fitsviewer/fitsviewer.cpp <span style="color: grey">(d5c3fcb)</span></li>

 <li>kstars/printing/pwizfovsh.cpp <span style="color: grey">(b5a4101)</span></li>

 <li>kstars/printing/pwizobjectselection.cpp <span style="color: \
grey">(50b9f5a)</span></li>

 <li>kstars/skyobjects/satellite.cpp <span style="color: grey">(0ca44f7)</span></li>

 <li>kstars/tools/conjunctions.cpp <span style="color: grey">(6b8c081)</span></li>

 <li>kstars/tools/modcalcvlsr.cpp <span style="color: grey">(2a9b355)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108184/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 