[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: kde-edu Digest, Vol 118, Issue 34
From: Laszlo Papp <lpapp () kde ! org>
Date: 2013-01-07 17:03:20
Message-ID: CAOMwXhNa4KFqCkNjYy05bdyaWhznnHDFPoOHWaLMPZr5Y9+Ziw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Including kstars-devel.
A clean build means an empty build directory before trying to avoid the
cmake cache generated from a previous run when there was an issue with the
build, but got fixed later.
Hopefully, you are doing shadow builds.
On Mon, Jan 7, 2013 at 12:14 PM, Punit Mehta <punit9462@gmail.com> wrote:
> Sorry but I dont get What do you mean by clean build ? ...It is showing
> errors so that make file can not be not generated..!!
>
>
> On Mon, Jan 7, 2013 at 4:37 AM, <kde-edu-request@mail.kde.org> wrote:
>
>> Send kde-edu mailing list submissions to
>> kde-edu@mail.kde.org
>>
>> To subscribe or unsubscribe via the World Wide Web, visit
>> https://mail.kde.org/mailman/listinfo/kde-edu
>> or, via email, send a message with subject or body 'help' to
>> kde-edu-request@mail.kde.org
>>
>> You can reach the person managing the list at
>> kde-edu-owner@mail.kde.org
>>
>> When replying, please edit your Subject line so it is more specific
>> than "Re: Contents of kde-edu digest..."
>>
>>
>> Today's Topics:
>>
>> 1. Re: Review Request: Fix Kstars Code: Explicit constructors #4
>> (Commit Hook)
>> 2. Problem in building KStars from its source (Punit Mehta)
>> 3. Re: Problem in building KStars from its source (Albert Astals Cid)
>> 4. Re: [Marble-devel] Review Request: fixed foreach loops code
>> checker issues (Jens-Michael Hoffmann)
>> 5. Re: Review Request: fixed foreach loops code checker issues
>> (Mohammed Nafees)
>>
>>
>> ----------------------------------------------------------------------
>>
>> Message: 1
>> Date: Sun, 06 Jan 2013 16:19:12 -0000
>> From: "Commit Hook" <null@kde.org>
>> To: "Kyle Morris" <codeinkyle@gmail.com>, "Commit Hook"
>> <null@kde.org>, "KDE Edu" <kde-edu@kde.org>
>> Subject: Re: Review Request: Fix Kstars Code: Explicit constructors #4
>> Message-ID: <20130106161912.7425.47465@vidsolbach.de>
>> Content-Type: text/plain; charset="utf-8"
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/108225/#review24844
>> -----------------------------------------------------------
>>
>>
>> This review has been submitted with commit
>> d29fb6a542b07cd92678255de52e620b52407642 by Kevin Krammer to branch master.
>>
>> - Commit Hook
>>
>>
>> On Jan. 6, 2013, 8:05 a.m., Kyle Morris wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > http://git.reviewboard.kde.org/r/108225/
>> > -----------------------------------------------------------
>> >
>> > (Updated Jan. 6, 2013, 8:05 a.m.)
>> >
>> >
>> > Review request for KDE Edu.
>> >
>> >
>> > Description
>> > -------
>> >
>> > Fix Kstars Code: Explicit constructors #4
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > kstars/kswizard.h eef9663
>> > kstars/skycomponents/cometscomponent.h 940b10c
>> > kstars/skycomponents/constellationboundarylines.h b2561ae
>> > kstars/skycomponents/equator.h b8e9305
>> > kstars/skycomponents/flagcomponent.h b5d4f0f
>> > kstars/skycomponents/listcomponent.h bd43b25
>> > kstars/skycomponents/milkyway.h df12f23
>> > kstars/skycomponents/solarsystemlistcomponent.h 63c26fa
>> > kstars/skycomponents/supernovaecomponent.h c0ecb15
>> > kstars/skymapgldraw.h c99c48e
>> > kstars/tools/altvstime.h e92d76a
>> > kstars/tools/conjunctions.h 2ba8bfd
>> > kstars/tools/flagmanager.h e7697c5
>> > kstars/tools/modcalcaltaz.h f862bd6
>> > kstars/tools/modcalcangdist.h 23062f0
>> > kstars/tools/modcalcdaylength.h 87cb4ed
>> > kstars/tools/modcalcjd.h 6e4b09b
>> > kstars/tools/modcalcplanets.h 335bce3
>> > kstars/tools/modcalcvlsr.h 2024460
>> > kstars/tools/scriptbuilder.h 467ce86
>> > kstars/tools/scriptfunction.h 2b35363
>> >
>> > Diff: http://git.reviewboard.kde.org/r/108225/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Kyle Morris
>> >
>> >
>>
>> -------------- next part --------------
>> An HTML attachment was scrubbed...
>> URL: <
>> http://mail.kde.org/pipermail/kde-edu/attachments/20130106/60decb4a/attachment-0001.html
>> >
>>
>> ------------------------------
>>
>> Message: 2
>> Date: Sun, 6 Jan 2013 23:20:07 +0530
>> From: Punit Mehta <punit9462@gmail.com>
>> To: kde-edu@mail.kde.org
>> Subject: Problem in building KStars from its source
>> Message-ID:
>> <
>> CAD5dDz8-Eg2dVTmcRKixU6sPXKeK6P-fodLXZPtj2BwWE176bw@mail.gmail.com>
>> Content-Type: text/plain; charset="iso-8859-1"
>>
>> Hi ,
>> I am finding a problem in installing KStars from its source.It is
>> showing that all the necessary libraries are found in the system but still
>> some variables are set to NOT found. I am not able to get which variables
>> are not set or which other libraries I need to install..?..the Konsole is
>> showing the following output :
>> ----------------------------------------------
>> punit1@ubuntu:~/kstars/build$ cmake ~/kstars/
>> -DCMAKE_BUILD_TYPE=debugfull -DKDE4_BUILD_TESTS=TRUE
>> -DCMAKE_INSTALL_PREFIX=$KDEDIR
>> -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
>> -- Found X11: /usr/lib/i386-linux-gnu/libX11.so
>> -- Found KDE 4.8 include dir: /usr/include
>> -- Found KDE 4.8 library dir: /usr/lib
>> -- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler
>> -- Found automoc4: /usr/bin/automoc4
>> -- Found CFITSIO: /usr/local/lib/libcfitsio.a
>> -- Found INDI: /usr/lib/libindi.so
>> -- Found WCSLIB: /usr/local/lib/libwcs.so, /usr/local/include/wcslib
>> -- Found Xplanet: /usr/bin/xplanet
>> CMake Error: File /home/punit1/kstars/config-kstars.h.cmake does not
>> exist.
>> CMake Error at CMakeLists.txt:46 (configure_file):
>> configure_file Problem configuring file
>>
>>
>> -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
>> -- Found X11: /usr/lib/i386-linux-gnu/libX11.so
>>
>>
>> -----------------------------------------------------------------------------
>> -- The following external packages were located on your system.
>> -- This installation will have the extra features provided by these
>> packages.
>>
>> -----------------------------------------------------------------------------
>> * Eigen2 - Required to build KStars.
>> * libcfitsio0 - Support for the FITS (Flexible Image Transport System)
>> data format in KStars.
>> * libindi - Support for controlling astronomical devices with KStars.
>> * WCSLib - Support for World Coordinate System in KStars.
>> * XPlanet - Renders an image of all the major planets and most
>> satellites
>> * OpenGL - Support for hardware rendering in KStars.
>>
>>
>> -----------------------------------------------------------------------------
>> -- Congratulations! All external packages have been found.
>>
>> -----------------------------------------------------------------------------
>>
>> CMake Error: The following variables are used in this project, but they
>> are
>> set to NOTFOUND.
>> Please set them or make sure they are set and tested correctly in the
>> CMake
>> files:
>> INDI_CLIENT_LIBRARIES (ADVANCED)
>> linked by target "KStarsLib" in directory /home/punit1/kstars/kstars
>>
>> -- Configuring incomplete, errors occurred!
>> punit1@ubuntu:~/kstars/build$
>> --------------------------------------------------------
>> thank a lot in advance.!! :)
>>
>> Regards,
>> Punit Mehta
>> -------------- next part --------------
>> An HTML attachment was scrubbed...
>> URL: <
>> http://mail.kde.org/pipermail/kde-edu/attachments/20130106/8d2aa508/attachment-0001.html
>> >
>>
>> ------------------------------
>>
>> Message: 3
>> Date: Sun, 06 Jan 2013 20:53:37 +0100
>> From: Albert Astals Cid <aacid@kde.org>
>> To: kde-edu@kde.org
>> Subject: Re: Problem in building KStars from its source
>> Message-ID: <2107506.lUatfgq2yP@xps>
>> Content-Type: text/plain; charset="us-ascii"
>>
>> El Diumenge, 6 de gener de 2013, a les 23:20:07, Punit Mehta va escriure:
>> > Hi ,
>> > I am finding a problem in installing KStars from its source.It
>> is
>> > showing that all the necessary libraries are found in the system but
>> still
>> > some variables are set to NOT found. I am not able to get which
>> variables
>> > are not set or which other libraries I need to install..?..the Konsole
>> is
>> > showing the following output :
>>
>> Is this a clean build?
>>
>> Cheers,
>> Albert
>>
>> > ----------------------------------------------
>> > punit1@ubuntu:~/kstars/build$ cmake ~/kstars/
>> > -DCMAKE_BUILD_TYPE=debugfull -DKDE4_BUILD_TESTS=TRUE
>> > -DCMAKE_INSTALL_PREFIX=$KDEDIR
>> > -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
>> > -- Found X11: /usr/lib/i386-linux-gnu/libX11.so
>> > -- Found KDE 4.8 include dir: /usr/include
>> > -- Found KDE 4.8 library dir: /usr/lib
>> > -- Found the KDE4 kconfig_compiler preprocessor:
>> /usr/bin/kconfig_compiler
>> > -- Found automoc4: /usr/bin/automoc4
>> > -- Found CFITSIO: /usr/local/lib/libcfitsio.a
>> > -- Found INDI: /usr/lib/libindi.so
>> > -- Found WCSLIB: /usr/local/lib/libwcs.so, /usr/local/include/wcslib
>> > -- Found Xplanet: /usr/bin/xplanet
>> > CMake Error: File /home/punit1/kstars/config-kstars.h.cmake does not
>> exist.
>> > CMake Error at CMakeLists.txt:46 (configure_file):
>> > configure_file Problem configuring file
>> >
>> >
>> > -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
>> > -- Found X11: /usr/lib/i386-linux-gnu/libX11.so
>> >
>> >
>> ----------------------------------------------------------------------------
>> > - -- The following external packages were located on your system.
>> > -- This installation will have the extra features provided by these
>> > packages.
>> >
>> ----------------------------------------------------------------------------
>> > - * Eigen2 - Required to build KStars.
>> > * libcfitsio0 - Support for the FITS (Flexible Image Transport
>> System)
>> > data format in KStars.
>> > * libindi - Support for controlling astronomical devices with KStars.
>> > * WCSLib - Support for World Coordinate System in KStars.
>> > * XPlanet - Renders an image of all the major planets and most
>> satellites
>> > * OpenGL - Support for hardware rendering in KStars.
>> >
>> >
>> ----------------------------------------------------------------------------
>> > - -- Congratulations! All external packages have been found.
>> >
>> ----------------------------------------------------------------------------
>> > -
>> >
>> > CMake Error: The following variables are used in this project, but they
>> are
>> > set to NOTFOUND.
>> > Please set them or make sure they are set and tested correctly in the
>> CMake
>> > files:
>> > INDI_CLIENT_LIBRARIES (ADVANCED)
>> > linked by target "KStarsLib" in directory /home/punit1/kstars/kstars
>> >
>> > -- Configuring incomplete, errors occurred!
>> > punit1@ubuntu:~/kstars/build$
>> > --------------------------------------------------------
>> > thank a lot in advance.!! :)
>> >
>> > Regards,
>> > Punit Mehta
>>
>>
>> ------------------------------
>>
>> Message: 4
>> Date: Sun, 6 Jan 2013 22:22:45 +0100
>> From: "Jens-Michael Hoffmann" <jmho@jmho.de>
>> To: marble-devel@kde.org, Kevin Krammer <krammer@kde.org>
>> Cc: KDE Edu <kde-edu@kde.org>
>> Subject: Re: [Marble-devel] Review Request: fixed foreach loops code
>> checker issues
>> Message-ID: <201301062222.45470.jmho@jmho.de>
>> Content-Type: Text/Plain; charset="iso-8859-15"
>>
>> Am Sonntag, 6. Januar 2013, 17:40:11 schrieb Kevin Krammer:
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > http://git.reviewboard.kde.org/r/108217/#review24845
>> > -----------------------------------------------------------
>> >
>> >
>> > Consider this review more as a hint for how to handle this in
>> applications
>> > where the developers care about performance of such loops. Obviously the
>> > developers here are fine with incurring lookups on each iteration
>> > otherwise they would not have used foreach on keys() or values() in the
>> > first place
>> >
>> >
>> > src/lib/FileManager.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19068>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > src/lib/FileManager.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19069>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > src/lib/FileManager.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19064>
>> >
>> > no, this is a lookup, the iterator has a value() method that returns
>> > the value the iterator points to
>> >
>> >
>> >
>> > src/lib/StackedTileLoader.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19065>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > src/lib/StackedTileLoader.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19066>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > src/lib/routing/RouteAnnotator.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19070>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > src/lib/routing/RouteAnnotator.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19071>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > src/lib/routing/RouteAnnotator.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19072>
>> >
>> > no, this is an unneeded lookup
>> > itpoint.value() does the same more efficiently
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19073>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19074>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19075>
>> >
>> > unneeded lookup overhead, use itpoint.value() instead
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19076>
>> >
>> > unneeded lookup overhead, use itpoint.value() instead
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19077>
>> >
>> > unneeded lookup overhead, use itpoint.value() instead
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19078>
>> >
>> > unneeded lookup overhead, use itpoint.value() instead
>> >
>> >
>> >
>> > src/plugins/render/opencaching/OpenCachingModel.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19079>
>> >
>> > unneeded lookup overhead, use itpoint.value() instead
>> >
>> >
>> >
>> > tests/RenderPluginTest.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19080>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tests/RenderPluginTest.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19081>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > tests/RenderPluginTest.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19082>
>> >
>> > unneeded lookup overhead at expected->settings().value(), use
>> > itpoint.value() instead
>> >
>> >
>> >
>> > tests/TestGeoDataWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19083>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tests/TestGeoDataWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19084>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19085>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19086>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19087>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19088>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19089>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tests/TestGeoSceneWriter.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19090>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> >
>> > tools/osm-addresses/OsmParser.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19091>
>> >
>> > const_iterator, constBegin
>> >
>> >
>> >
>> > tools/osm-addresses/OsmParser.cpp
>> > <http://git.reviewboard.kde.org/r/108217/#comment19092>
>> >
>> > const_iterator, constEnd
>> >
>> >
>> > - Kevin Krammer
>> >
>>
>> Thanks for the thorough review, it is very much appreciated. These are
>> indeed
>> important points.
>>
>>
>> kind regards,
>> Jens-Michael
>>
>>
>>
>> ------------------------------
>>
>> Message: 5
>> Date: Sun, 06 Jan 2013 12:27:36 -0000
>> From: "Mohammed Nafees" <nafees.technocool@gmail.com>
>> To: "Kevin Krammer" <krammer@kde.org>
>> Cc: KDE Edu <kde-edu@kde.org>, Akarsh Simha
>> <akarsh.simha@kdemail.net>, Marble <marble-devel@kde.org>,
>> Mohammed
>> Nafees <nafees.technocool@gmail.com>
>> Subject: Re: Review Request: fixed foreach loops code checker issues
>> Message-ID: <20130106122736.28749.78969@vidsolbach.de>
>> Content-Type: text/plain; charset="utf-8"
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/108217/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 6, 2013, 12:27 p.m.)
>>
>>
>> Review request for KDE Edu, Marble and Kevin Krammer.
>>
>>
>> Description
>> -------
>>
>> http://www.google-melange.com/gci/task/view/google/gci2012/8159207
>>
>> fixed Krazy issues on foreach loops
>>
>>
>> Diffs (updated)
>> -----
>>
>> tests/TestGeoSceneWriter.cpp 222e22f
>> tests/TestGeoDataWriter.cpp a25ba95
>> src/lib/FileManager.cpp 2bac816
>> src/lib/StackedTileLoader.cpp 962bfef
>> src/lib/routing/RouteAnnotator.cpp bf5e6f7
>> src/plugins/render/opencaching/OpenCachingModel.cpp e333168
>> tests/ProjectionTest.cpp ce6e5d1
>> tests/RenderPluginTest.cpp f7dd2e3
>> tools/osm-addresses/OsmParser.cpp 1a24066
>>
>> Diff: http://git.reviewboard.kde.org/r/108217/diff/
>>
>>
>> Testing
>> -------
>>
>> yes
>>
>>
>> Thanks,
>>
>> Mohammed Nafees
>>
>> -------------- next part --------------
>> An HTML attachment was scrubbed...
>> URL: <
>> http://mail.kde.org/pipermail/kde-edu/attachments/20130106/62b3f36c/attachment.html
>> >
>>
>> ------------------------------
>>
>> _______________________________________________
>> kde-edu mailing list
>> kde-edu@mail.kde.org
>> https://mail.kde.org/mailman/listinfo/kde-edu
>>
>>
>> End of kde-edu Digest, Vol 118, Issue 34
>> ****************************************
>>
>
>
> _______________________________________________
> kde-edu mailing list
> kde-edu@mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
>
>
[Attachment #5 (text/html)]
Including kstars-devel.<br><br>A clean build means an empty build directory before \
trying to avoid the cmake cache generated from a previous run when there was an issue \
with the build, but got fixed later.<br><br>Hopefully, you are doing shadow \
builds.<br> <br><div class="gmail_quote">On Mon, Jan 7, 2013 at 12:14 PM, Punit Mehta \
<span dir="ltr"><<a href="mailto:punit9462@gmail.com" \
target="_blank">punit9462@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Sorry but I dont get What do you mean by clean build ? ...It \
is showing errors so that make file can not be not generated..!! <br><br><br><div \
class="gmail_quote">On Mon, Jan 7, 2013 at 4:37 AM, <span dir="ltr"><<a \
href="mailto:kde-edu-request@mail.kde.org" \
target="_blank">kde-edu-request@mail.kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Send kde-edu mailing list submissions to<br>
<a href="mailto:kde-edu@mail.kde.org" \
target="_blank">kde-edu@mail.kde.org</a><br> <br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://mail.kde.org/mailman/listinfo/kde-edu" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br> or, via email, \
send a message with subject or body 'help' to<br>
<a href="mailto:kde-edu-request@mail.kde.org" \
target="_blank">kde-edu-request@mail.kde.org</a><br> <br>
You can reach the person managing the list at<br>
<a href="mailto:kde-edu-owner@mail.kde.org" \
target="_blank">kde-edu-owner@mail.kde.org</a><br> <br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of kde-edu digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: Review Request: Fix Kstars Code: Explicit constructors #4<br>
(Commit Hook)<br>
2. Problem in building KStars from its source (Punit Mehta)<br>
3. Re: Problem in building KStars from its source (Albert Astals Cid)<br>
4. Re: [Marble-devel] Review Request: fixed foreach loops code<br>
checker issues (Jens-Michael Hoffmann)<br>
5. Re: Review Request: fixed foreach loops code checker issues<br>
(Mohammed Nafees)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Sun, 06 Jan 2013 16:19:12 -0000<br>
From: "Commit Hook" <<a href="mailto:null@kde.org" \
target="_blank">null@kde.org</a>><br>
To: "Kyle Morris" <<a href="mailto:codeinkyle@gmail.com" \
target="_blank">codeinkyle@gmail.com</a>>, "Commit Hook"<br> <<a \
href="mailto:null@kde.org" target="_blank">null@kde.org</a>>, "KDE Edu" \
<<a href="mailto:kde-edu@kde.org" \
target="_blank">kde-edu@kde.org</a>><br>
Subject: Re: Review Request: Fix Kstars Code: Explicit constructors #4<br>
Message-ID: <<a href="mailto:20130106161912.7425.47465@vidsolbach.de" \
target="_blank">20130106161912.7425.47465@vidsolbach.de</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://git.reviewboard.kde.org/r/108225/#review24844" \
target="_blank">http://git.reviewboard.kde.org/r/108225/#review24844</a><br>
-----------------------------------------------------------<br>
<br>
<br>
This review has been submitted with commit d29fb6a542b07cd92678255de52e620b52407642 \
by Kevin Krammer to branch master.<br> <br>
- Commit Hook<br>
<br>
<br>
On Jan. 6, 2013, 8:05 a.m., Kyle Morris wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://git.reviewboard.kde.org/r/108225/" \
target="_blank">http://git.reviewboard.kde.org/r/108225/</a><br> > \
-----------------------------------------------------------<br> ><br>
> (Updated Jan. 6, 2013, 8:05 a.m.)<br>
><br>
><br>
> Review request for KDE Edu.<br>
><br>
><br>
> Description<br>
> -------<br>
><br>
> Fix Kstars Code: Explicit constructors #4<br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> kstars/kswizard.h eef9663<br>
> kstars/skycomponents/cometscomponent.h 940b10c<br>
> kstars/skycomponents/constellationboundarylines.h b2561ae<br>
> kstars/skycomponents/equator.h b8e9305<br>
> kstars/skycomponents/flagcomponent.h b5d4f0f<br>
> kstars/skycomponents/listcomponent.h bd43b25<br>
> kstars/skycomponents/milkyway.h df12f23<br>
> kstars/skycomponents/solarsystemlistcomponent.h 63c26fa<br>
> kstars/skycomponents/supernovaecomponent.h c0ecb15<br>
> kstars/skymapgldraw.h c99c48e<br>
> kstars/tools/altvstime.h e92d76a<br>
> kstars/tools/conjunctions.h 2ba8bfd<br>
> kstars/tools/flagmanager.h e7697c5<br>
> kstars/tools/modcalcaltaz.h f862bd6<br>
> kstars/tools/modcalcangdist.h 23062f0<br>
> kstars/tools/modcalcdaylength.h 87cb4ed<br>
> kstars/tools/modcalcjd.h 6e4b09b<br>
> kstars/tools/modcalcplanets.h 335bce3<br>
> kstars/tools/modcalcvlsr.h 2024460<br>
> kstars/tools/scriptbuilder.h 467ce86<br>
> kstars/tools/scriptfunction.h 2b35363<br>
><br>
> Diff: <a href="http://git.reviewboard.kde.org/r/108225/diff/" \
target="_blank">http://git.reviewboard.kde.org/r/108225/diff/</a><br> ><br>
><br>
> Testing<br>
> -------<br>
><br>
><br>
> Thanks,<br>
><br>
> Kyle Morris<br>
><br>
><br>
<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mail.kde.org/pipermail/kde-edu/attachments/20130106/60decb4a/attachment-0001.html" \
target="_blank">http://mail.kde.org/pipermail/kde-edu/attachments/20130106/60decb4a/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Sun, 6 Jan 2013 23:20:07 +0530<br>
From: Punit Mehta <<a href="mailto:punit9462@gmail.com" \
target="_blank">punit9462@gmail.com</a>><br>
To: <a href="mailto:kde-edu@mail.kde.org" \
target="_blank">kde-edu@mail.kde.org</a><br>
Subject: Problem in building KStars from its source<br>
Message-ID:<br>
<<a href="mailto:CAD5dDz8-Eg2dVTmcRKixU6sPXKeK6P-fodLXZPtj2BwWE176bw@mail.gmail.com" \
target="_blank">CAD5dDz8-Eg2dVTmcRKixU6sPXKeK6P-fodLXZPtj2BwWE176bw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="iso-8859-1"<br>
<br>
Hi ,<br>
I am finding a problem in installing KStars from its source.It is<br>
showing that all the necessary libraries are found in the system but still<br>
some variables are set to NOT found. I am not able to get which variables<br>
are not set or which other libraries I need to install..?..the Konsole is<br>
showing the following output :<br>
----------------------------------------------<br>
punit1@ubuntu:~/kstars/build$ cmake ~/kstars/<br>
-DCMAKE_BUILD_TYPE=debugfull -DKDE4_BUILD_TESTS=TRUE<br>
-DCMAKE_INSTALL_PREFIX=$KDEDIR<br>
-- Found Qt-Version 4.8.1 (using /usr/bin/qmake)<br>
-- Found X11: /usr/lib/i386-linux-gnu/libX11.so<br>
-- Found KDE 4.8 include dir: /usr/include<br>
-- Found KDE 4.8 library dir: /usr/lib<br>
-- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler<br>
-- Found automoc4: /usr/bin/automoc4<br>
-- Found CFITSIO: /usr/local/lib/libcfitsio.a<br>
-- Found INDI: /usr/lib/libindi.so<br>
-- Found WCSLIB: /usr/local/lib/libwcs.so, /usr/local/include/wcslib<br>
-- Found Xplanet: /usr/bin/xplanet<br>
CMake Error: File /home/punit1/kstars/config-kstars.h.cmake does not exist.<br>
CMake Error at CMakeLists.txt:46 (configure_file):<br>
configure_file Problem configuring file<br>
<br>
<br>
-- Found Qt-Version 4.8.1 (using /usr/bin/qmake)<br>
-- Found X11: /usr/lib/i386-linux-gnu/libX11.so<br>
<br>
-----------------------------------------------------------------------------<br>
-- The following external packages were located on your system.<br>
-- This installation will have the extra features provided by these<br>
packages.<br>
-----------------------------------------------------------------------------<br>
* Eigen2 - Required to build KStars.<br>
* libcfitsio0 - Support for the FITS (Flexible Image Transport System)<br>
data format in KStars.<br>
* libindi - Support for controlling astronomical devices with KStars.<br>
* WCSLib - Support for World Coordinate System in KStars.<br>
* XPlanet - Renders an image of all the major planets and most satellites<br>
* OpenGL - Support for hardware rendering in KStars.<br>
<br>
-----------------------------------------------------------------------------<br>
-- Congratulations! All external packages have been found.<br>
-----------------------------------------------------------------------------<br>
<br>
CMake Error: The following variables are used in this project, but they are<br>
set to NOTFOUND.<br>
Please set them or make sure they are set and tested correctly in the CMake<br>
files:<br>
INDI_CLIENT_LIBRARIES (ADVANCED)<br>
linked by target "KStarsLib" in directory \
/home/punit1/kstars/kstars<br> <br>
-- Configuring incomplete, errors occurred!<br>
punit1@ubuntu:~/kstars/build$<br>
--------------------------------------------------------<br>
thank a lot in advance.!! :)<br>
<br>
Regards,<br>
Punit Mehta<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mail.kde.org/pipermail/kde-edu/attachments/20130106/8d2aa508/attachment-0001.html" \
target="_blank">http://mail.kde.org/pipermail/kde-edu/attachments/20130106/8d2aa508/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Sun, 06 Jan 2013 20:53:37 +0100<br>
From: Albert Astals Cid <<a href="mailto:aacid@kde.org" \
target="_blank">aacid@kde.org</a>><br>
To: <a href="mailto:kde-edu@kde.org" target="_blank">kde-edu@kde.org</a><br>
Subject: Re: Problem in building KStars from its source<br>
Message-ID: <2107506.lUatfgq2yP@xps><br>
Content-Type: text/plain; charset="us-ascii"<br>
<br>
El Diumenge, 6 de gener de 2013, a les 23:20:07, Punit Mehta va escriure:<br>
> Hi ,<br>
> I am finding a problem in installing KStars from its source.It is<br>
> showing that all the necessary libraries are found in the system but still<br>
> some variables are set to NOT found. I am not able to get which variables<br>
> are not set or which other libraries I need to install..?..the Konsole is<br>
> showing the following output :<br>
<br>
Is this a clean build?<br>
<br>
Cheers,<br>
Albert<br>
<br>
> ----------------------------------------------<br>
> punit1@ubuntu:~/kstars/build$ cmake ~/kstars/<br>
> -DCMAKE_BUILD_TYPE=debugfull -DKDE4_BUILD_TESTS=TRUE<br>
> -DCMAKE_INSTALL_PREFIX=$KDEDIR<br>
> -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)<br>
> -- Found X11: /usr/lib/i386-linux-gnu/libX11.so<br>
> -- Found KDE 4.8 include dir: /usr/include<br>
> -- Found KDE 4.8 library dir: /usr/lib<br>
> -- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler<br>
> -- Found automoc4: /usr/bin/automoc4<br>
> -- Found CFITSIO: /usr/local/lib/libcfitsio.a<br>
> -- Found INDI: /usr/lib/libindi.so<br>
> -- Found WCSLIB: /usr/local/lib/libwcs.so, /usr/local/include/wcslib<br>
> -- Found Xplanet: /usr/bin/xplanet<br>
> CMake Error: File /home/punit1/kstars/config-kstars.h.cmake does not exist.<br>
> CMake Error at CMakeLists.txt:46 (configure_file):<br>
> configure_file Problem configuring file<br>
><br>
><br>
> -- Found Qt-Version 4.8.1 (using /usr/bin/qmake)<br>
> -- Found X11: /usr/lib/i386-linux-gnu/libX11.so<br>
><br>
> ----------------------------------------------------------------------------<br>
> - -- The following external packages were located on your system.<br>
> -- This installation will have the extra features provided by these<br>
> packages.<br>
> ----------------------------------------------------------------------------<br>
> - * Eigen2 - Required to build KStars.<br>
> * libcfitsio0 - Support for the FITS (Flexible Image Transport System)<br>
> data format in KStars.<br>
> * libindi - Support for controlling astronomical devices with KStars.<br>
> * WCSLib - Support for World Coordinate System in KStars.<br>
> * XPlanet - Renders an image of all the major planets and most satellites<br>
> * OpenGL - Support for hardware rendering in KStars.<br>
><br>
> ----------------------------------------------------------------------------<br>
> - -- Congratulations! All external packages have been found.<br>
> ----------------------------------------------------------------------------<br>
> -<br>
><br>
> CMake Error: The following variables are used in this project, but they are<br>
> set to NOTFOUND.<br>
> Please set them or make sure they are set and tested correctly in the CMake<br>
> files:<br>
> INDI_CLIENT_LIBRARIES (ADVANCED)<br>
> linked by target "KStarsLib" in directory \
/home/punit1/kstars/kstars<br> ><br>
> -- Configuring incomplete, errors occurred!<br>
> punit1@ubuntu:~/kstars/build$<br>
> --------------------------------------------------------<br>
> thank a lot in advance.!! :)<br>
><br>
> Regards,<br>
> Punit Mehta<br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Sun, 6 Jan 2013 22:22:45 +0100<br>
From: "Jens-Michael Hoffmann" <<a href="mailto:jmho@jmho.de" \
target="_blank">jmho@jmho.de</a>><br>
To: <a href="mailto:marble-devel@kde.org" target="_blank">marble-devel@kde.org</a>, \
Kevin Krammer <<a href="mailto:krammer@kde.org" \
target="_blank">krammer@kde.org</a>><br>
Cc: KDE Edu <<a href="mailto:kde-edu@kde.org" \
target="_blank">kde-edu@kde.org</a>><br>
Subject: Re: [Marble-devel] Review Request: fixed foreach loops code<br>
checker issues<br>
Message-ID: <<a href="mailto:201301062222.45470.jmho@jmho.de" \
target="_blank">201301062222.45470.jmho@jmho.de</a>><br>
Content-Type: Text/Plain; charset="iso-8859-15"<br>
<br>
Am Sonntag, 6. Januar 2013, 17:40:11 schrieb Kevin Krammer:<br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://git.reviewboard.kde.org/r/108217/#review24845" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#review24845</a><br> > \
-----------------------------------------------------------<br> ><br>
><br>
> Consider this review more as a hint for how to handle this in applications<br>
> where the developers care about performance of such loops. Obviously the<br>
> developers here are fine with incurring lookups on each iteration<br>
> otherwise they would not have used foreach on keys() or values() in the<br>
> first place<br>
><br>
><br>
> src/lib/FileManager.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19068" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19068</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> src/lib/FileManager.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19069" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19069</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> src/lib/FileManager.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19064" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19064</a>><br> \
><br> > no, this is a lookup, the iterator has a value() method that \
returns<br> > the value the iterator points to<br>
><br>
><br>
><br>
> src/lib/StackedTileLoader.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19065" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19065</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> src/lib/StackedTileLoader.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19066" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19066</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> src/lib/routing/RouteAnnotator.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19070" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19070</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> src/lib/routing/RouteAnnotator.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19071" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19071</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> src/lib/routing/RouteAnnotator.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19072" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19072</a>><br> \
><br> > no, this is an unneeded lookup<br>
> itpoint.value() does the same more efficiently<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19073" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19073</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19074" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19074</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19075" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19075</a>><br> \
><br> > unneeded lookup overhead, use itpoint.value() instead<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19076" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19076</a>><br> \
><br> > unneeded lookup overhead, use itpoint.value() instead<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19077" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19077</a>><br> \
><br> > unneeded lookup overhead, use itpoint.value() instead<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19078" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19078</a>><br> \
><br> > unneeded lookup overhead, use itpoint.value() instead<br>
><br>
><br>
><br>
> src/plugins/render/opencaching/OpenCachingModel.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19079" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19079</a>><br> \
><br> > unneeded lookup overhead, use itpoint.value() instead<br>
><br>
><br>
><br>
> tests/RenderPluginTest.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19080" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19080</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tests/RenderPluginTest.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19081" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19081</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> tests/RenderPluginTest.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19082" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19082</a>><br> \
><br> > unneeded lookup overhead at expected->settings().value(), \
use<br> > itpoint.value() instead<br>
><br>
><br>
><br>
> tests/TestGeoDataWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19083" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19083</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tests/TestGeoDataWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19084" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19084</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19085" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19085</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19086" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19086</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19087" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19087</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19088" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19088</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19089" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19089</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tests/TestGeoSceneWriter.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19090" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19090</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
><br>
> tools/osm-addresses/OsmParser.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19091" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19091</a>><br> \
><br> > const_iterator, constBegin<br>
><br>
><br>
><br>
> tools/osm-addresses/OsmParser.cpp<br>
> <<a href="http://git.reviewboard.kde.org/r/108217/#comment19092" \
target="_blank">http://git.reviewboard.kde.org/r/108217/#comment19092</a>><br> \
><br> > const_iterator, constEnd<br>
><br>
><br>
> - Kevin Krammer<br>
><br>
<br>
Thanks for the thorough review, it is very much appreciated. These are indeed<br>
important points.<br>
<br>
<br>
kind regards,<br>
Jens-Michael<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 5<br>
Date: Sun, 06 Jan 2013 12:27:36 -0000<br>
From: "Mohammed Nafees" <<a href="mailto:nafees.technocool@gmail.com" \
target="_blank">nafees.technocool@gmail.com</a>><br>
To: "Kevin Krammer" <<a href="mailto:krammer@kde.org" \
target="_blank">krammer@kde.org</a>><br>
Cc: KDE Edu <<a href="mailto:kde-edu@kde.org" \
target="_blank">kde-edu@kde.org</a>>, Akarsh Simha<br> <<a \
href="mailto:akarsh.simha@kdemail.net" \
target="_blank">akarsh.simha@kdemail.net</a>>, Marble <<a \
href="mailto:marble-devel@kde.org" target="_blank">marble-devel@kde.org</a>>, \
Mohammed<br>
Nafees <<a href="mailto:nafees.technocool@gmail.com" \
target="_blank">nafees.technocool@gmail.com</a>><br>
Subject: Re: Review Request: fixed foreach loops code checker issues<br>
Message-ID: <<a href="mailto:20130106122736.28749.78969@vidsolbach.de" \
target="_blank">20130106122736.28749.78969@vidsolbach.de</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://git.reviewboard.kde.org/r/108217/" \
target="_blank">http://git.reviewboard.kde.org/r/108217/</a><br>
-----------------------------------------------------------<br>
<br>
(Updated Jan. 6, 2013, 12:27 p.m.)<br>
<br>
<br>
Review request for KDE Edu, Marble and Kevin Krammer.<br>
<br>
<br>
Description<br>
-------<br>
<br>
<a href="http://www.google-melange.com/gci/task/view/google/gci2012/8159207" \
target="_blank">http://www.google-melange.com/gci/task/view/google/gci2012/8159207</a><br>
<br>
fixed Krazy issues on foreach loops<br>
<br>
<br>
Diffs (updated)<br>
-----<br>
<br>
tests/TestGeoSceneWriter.cpp 222e22f<br>
tests/TestGeoDataWriter.cpp a25ba95<br>
src/lib/FileManager.cpp 2bac816<br>
src/lib/StackedTileLoader.cpp 962bfef<br>
src/lib/routing/RouteAnnotator.cpp bf5e6f7<br>
src/plugins/render/opencaching/OpenCachingModel.cpp e333168<br>
tests/ProjectionTest.cpp ce6e5d1<br>
tests/RenderPluginTest.cpp f7dd2e3<br>
tools/osm-addresses/OsmParser.cpp 1a24066<br>
<br>
Diff: <a href="http://git.reviewboard.kde.org/r/108217/diff/" \
target="_blank">http://git.reviewboard.kde.org/r/108217/diff/</a><br> <br>
<br>
Testing<br>
-------<br>
<br>
yes<br>
<br>
<br>
Thanks,<br>
<br>
Mohammed Nafees<br>
<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mail.kde.org/pipermail/kde-edu/attachments/20130106/62b3f36c/attachment.html" \
target="_blank">http://mail.kde.org/pipermail/kde-edu/attachments/20130106/62b3f36c/attachment.html</a>><br>
<br>
------------------------------<br>
<br>
_______________________________________________<br>
kde-edu mailing list<br>
<a href="mailto:kde-edu@mail.kde.org" target="_blank">kde-edu@mail.kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-edu" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br> <br>
<br>
End of kde-edu Digest, Vol 118, Issue 34<br>
****************************************<br>
</blockquote></div><br>
<br>_______________________________________________<br>
kde-edu mailing list<br>
<a href="mailto:kde-edu@mail.kde.org">kde-edu@mail.kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-edu" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br> \
<br></blockquote></div><br>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic