[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: fixed foreach loops code checker issues
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2013-01-06 16:40:11
Message-ID: 20130106164011.12748.81478 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108217/#review24845
-----------------------------------------------------------
Consider this review more as a hint for how to handle this in applications =
where the developers care about performance of such loops.
Obviously the developers here are fine with incurring lookups on each itera=
tion otherwise they would not have used foreach on keys() or values() in th=
e first place
src/lib/FileManager.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19068>
const_iterator, constBegin
src/lib/FileManager.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19069>
const_iterator, constBegin
src/lib/FileManager.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19064>
no, this is a lookup, the iterator has a value() method that returns th=
e value the iterator points to
src/lib/StackedTileLoader.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19065>
const_iterator, constBegin
src/lib/StackedTileLoader.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19066>
const_iterator, constEnd
src/lib/routing/RouteAnnotator.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19070>
const_iterator, constBegin
src/lib/routing/RouteAnnotator.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19071>
const_iterator, constEnd
src/lib/routing/RouteAnnotator.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19072>
no, this is an unneeded lookup
itpoint.value() does the same more efficiently
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19073>
const_iterator, constBegin
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19074>
const_iterator, constEnd
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19075>
unneeded lookup overhead, use itpoint.value() instead
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19076>
unneeded lookup overhead, use itpoint.value() instead
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19077>
unneeded lookup overhead, use itpoint.value() instead
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19078>
unneeded lookup overhead, use itpoint.value() instead
src/plugins/render/opencaching/OpenCachingModel.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19079>
unneeded lookup overhead, use itpoint.value() instead
tests/RenderPluginTest.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19080>
const_iterator, constBegin
tests/RenderPluginTest.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19081>
const_iterator, constEnd
tests/RenderPluginTest.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19082>
unneeded lookup overhead at expected->settings().value(), use itpoint.v=
alue() instead
tests/TestGeoDataWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19083>
const_iterator, constBegin
tests/TestGeoDataWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19084>
const_iterator, constEnd
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19085>
const_iterator, constBegin
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19086>
const_iterator, constEnd
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19087>
const_iterator, constBegin
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19088>
const_iterator, constEnd
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19089>
const_iterator, constBegin
tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19090>
const_iterator, constEnd
tools/osm-addresses/OsmParser.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19091>
const_iterator, constBegin
tools/osm-addresses/OsmParser.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19092>
const_iterator, constEnd
- Kevin Krammer
On Jan. 6, 2013, 1:59 p.m., Mohammed Nafees wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108217/
> -----------------------------------------------------------
> =
> (Updated Jan. 6, 2013, 1:59 p.m.)
> =
> =
> Review request for KDE Edu, Marble and Kevin Krammer.
> =
> =
> Description
> -------
> =
> http://www.google-melange.com/gci/task/view/google/gci2012/8159207
> =
> fixed Krazy issues on foreach loops
> =
> =
> Diffs
> -----
> =
> src/lib/FileManager.cpp 2bac816 =
> src/lib/StackedTileLoader.cpp 962bfef =
> src/lib/routing/RouteAnnotator.cpp bf5e6f7 =
> src/plugins/render/opencaching/OpenCachingModel.cpp e333168 =
> tests/ProjectionTest.cpp ce6e5d1 =
> tests/RenderPluginTest.cpp f7dd2e3 =
> tests/TestGeoDataWriter.cpp a25ba95 =
> tests/TestGeoSceneWriter.cpp 222e22f =
> tools/osm-addresses/OsmParser.cpp 1a24066 =
> =
> Diff: http://git.reviewboard.kde.org/r/108217/diff/
> =
> =
> Testing
> -------
> =
> yes
> =
> =
> Thanks,
> =
> Mohammed Nafees
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108217/">http://git.reviewboard.kde.org/r/108217/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Consider this review \
more as a hint for how to handle this in applications where the developers care about \
performance of such loops. Obviously the developers here are fine with incurring \
lookups on each iteration otherwise they would not have used foreach on keys() or \
values() in the first place</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105248#file105248line157" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/FileManager.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FileManager::saveFile( GeoDataDocument *document )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">157</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="n">QString</span> <span \
class="n">key</span><span class="p">,</span> <span class="n">d</span><span \
class="o">-></span><span class="n">m_fileItemHash</span><span \
class="p">.</span><span class="n">keys</span><span class="p">()</span> <span \
class="p">)</span> <span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">157</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QHash</span> <span class="o"><</span> <span \
class="n">QString</span><span class="p">,</span> <span \
class="n">GeoDataDocument</span><span class="o">*</span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="n">itpoint</span> \
<span class="o">=</span> <span class="n">d</span><span class="o">-></span><span \
class="n">m_fileItemHash</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105248#file105248line158" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/FileManager.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FileManager::saveFile( GeoDataDocument *document )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">158</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span> <span class="n">d</span><span \
class="o">-></span><span class="n">m_fileItemHash</span><span \
class="p">.</span><span class="n">value</span><span class="p">(</span> <span \
class="n">key</span> <span class="p">)</span> <span class="o">==</span> <span \
class="n">document</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">158</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QHash</span> <span \
class="o"><</span> <span class="n">QString</span><span class="p">,</span> <span \
class="n">GeoDataDocument</span><span class="o">*</span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">d</span><span class="o">-></span><span \
class="n">m_fileItemHash</span><span class="p">.</span><span \
class="n">end</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105248#file105248line160" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/FileManager.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FileManager::saveFile( GeoDataDocument *document )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">160</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span> <span class="n">d</span><span \
class="o">-></span><span class="n">m_fileItemHash</span><span \
class="p">.</span><span class="n">value</span><span class="p">(</span> <span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()</span> <span class="p">)</span> <span class="o">==</span> <span \
class="n">document</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, this is \
a lookup, the iterator has a value() method that returns the value the iterator \
points to</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105249#file105249line219" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/StackedTileLoader.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">quint64 StackedTileLoader::volatileCacheLimit() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">219</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">foreach</span></span><span class="hl"> </span><span class="p"><span \
class="hl">(</span></span><span class="hl"> </span><span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span \
class="n">TileId</span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="n"><span \
class="hl">s</span>tackedTile<span class="hl">Id</span></span><span class="p"><span \
class="hl">,</span></span> <span class="n">d</span><span class="o">-></span><span \
class="n">m_tilesOnDisplay</span><span class="p">.</span><span class="n"><span \
class="hl">keys</span></span><span class="p"><span class="hl">()</span></span><span \
class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> \
</span><span class="p"><span class="hl">{</span></span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">219</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QHash</span></span><span class="hl"> </span><span \
class="o"><span class="hl"><</span></span><span class="n">TileId</span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="n"><span class="hl">S</span>tackedTile</span><span class="o"><span \
class="hl">*>::</span></span><span class="n"><span \
class="hl">iterator</span></span><span class="hl"> </span><span class="n"><span \
class="hl">itpoint</span></span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span> <span class="n">d</span><span class="o">-></span><span \
class="n">m_tilesOnDisplay</span><span class="p">.</span><span class="n"><span \
class="hl">begin</span></span><span class="p"><span \
class="hl">();</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105249#file105249line220" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/StackedTileLoader.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">quint64 StackedTileLoader::volatileCacheLimit() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">220</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QVector</span><span class="o"><</span><span \
class="n">GeoSceneTiled</span> <span class="k">const</span> <span \
class="o">*></span> <span class="k">const</span> <span \
class="n">textureLayers</span> <span class="o">=</span> <span class="n">d</span><span \
class="o">-></span><span class="n">findRelevantTextureLayers</span><span \
class="p">(</span> <span class="n">stackedTileId</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">220</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QHash</span> <span \
class="o"><</span><span class="n">TileId</span><span class="p">,</span> <span \
class="n">StackedTile</span><span class="o">*>::</span><span \
class="n">iterator</span> <span class="k">const</span> <span \
class="n">endpoint</span> <span class="o">=</span> <span class="n">d</span><span \
class="o">-></span><span class="n">m_tilesOnDisplay</span><span \
class="p">.</span><span class="n">end</span><span class="p">();</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105250#file105250line126" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/routing/RouteAnnotator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RouteAnnotator::retrieveGeocodeResult( const GeoDataCoordinates &coordinates, \
const GeoDataPlacemark &placemark )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">126</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">key</span><span \
class="p">,</span> <span class="n">counter</span><span class="p">.</span><span \
class="n">keys</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">126</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span><span \
class="kt">int</span><span class="o">>::</span><span class="n">iterator</span> \
<span class="n">itpoint</span> <span class="o">=</span> <span \
class="n">counter</span><span class="p">.</span><span class="n">begin</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105250#file105250line127" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/routing/RouteAnnotator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RouteAnnotator::retrieveGeocodeResult( const GeoDataCoordinates &coordinates, \
const GeoDataPlacemark &placemark )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">127</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span class="n">counter</span><span \
class="p">[</span><span class="n">key</span><span class="p">]</span> <span \
class="o">></span> <span class="mi">1</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">127</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span><span \
class="kt">int</span><span class="o">>::</span><span class="n">iterator</span> \
<span class="k">const</span> <span class="n">endpoint</span> <span class="o">=</span> \
<span class="n">counter</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105250#file105250line129" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/routing/RouteAnnotator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RouteAnnotator::retrieveGeocodeResult( const GeoDataCoordinates &coordinates, \
const GeoDataPlacemark &placemark )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">129</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span> <span \
class="n">counter</span><span class="p">[</span><span class="n">itpoint</span><span \
class="p">.</span><span class="n">key</span><span class="p">()]</span> <span \
class="o">></span> <span class="mi">1</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, this is \
an unneeded lookup itpoint.value() does the same more efficiently</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line190" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">190</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span \
class="kt">int</span> <span class="n">key</span><span class="p">,</span> <span \
class="n">caches</span><span class="p">.</span><span class="n">keys</span><span \
class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">190</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QHash</span><span class="o"><</span><span class="kt">int</span><span \
class="p">,</span> <span class="n">OpenCachingCache</span><span \
class="o">>::</span><span class="n">iterator</span> <span class="n">itpoint</span> \
<span class="o">=</span> <span class="n">caches</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line191" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">191</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span> <span class="n">caches</span><span \
class="p">[</span><span class="n">key</span><span class="p">].</span><span \
class="n">difficulty</span><span class="p">()</span> <span class="o">>=</span> \
<span class="n">m_minDifficulty</span> <span class="o">&&</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">191</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QHash</span><span class="o"><</span><span class="kt">int</span><span \
class="p">,</span> <span class="n">OpenCachingCache</span><span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">caches</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line193" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">193</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">193</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span \
class="p">(</span> <span class="n">caches</span><span class="p">[</span><span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()].</span><span class="n">difficulty</span><span class="p">()</span> <span \
class="o">>=</span> <span class="n">m_minDifficulty</span> <span \
class="o">&&</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead, use itpoint.value() instead</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line194" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">194</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">caches</span><span class="p">[</span><span class="n">key</span><span \
class="p">].</span><span class="n">setDescription</span><span class="p">(</span> \
<span class="n">descriptions</span><span class="p">[</span><span \
class="n">key</span><span class="p">]</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">194</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">caches</span><span class="p">[</span><span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()].</span><span class="n">difficulty</span><span class="p">()</span> <span \
class="o"><=</span> <span class="n">m_maxDifficulty</span> <span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead, use itpoint.value() instead</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line196" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">196</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addItemToList</span><span class="p">(</span> <span class="k">new</span> \
<span class="n">OpenCachingItem</span><span class="p">(</span> <span \
class="n">caches</span><span class="p">[</span><span class="n">key</span><span \
class="p">],</span> <span class="k">this</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">196</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">caches</span><span \
class="p">[</span><span class="n">itpoint</span><span class="p">.</span><span \
class="n">key</span><span class="p">()].</span><span \
class="n">setDescription</span><span class="p">(</span> <span \
class="n">descriptions</span><span class="p">[</span><span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()]</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead, use itpoint.value() instead</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line197" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">197</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">caches</span><span class="p">[</span><span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()].</span><span class="n">setLog</span><span class="p">(</span> <span \
class="n">logs</span><span class="p">[</span><span class="n">itpoint</span><span \
class="p">.</span><span class="n">key</span><span class="p">()]</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead, use itpoint.value() instead</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105251#file105251line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/render/opencaching/OpenCachingModel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OpenCachingModel::parseFile( const QByteArray& file )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">addItemToList</span><span class="p">(</span> <span \
class="k">new</span> <span class="n">OpenCachingItem</span><span class="p">(</span> \
<span class="n">caches</span><span class="p">[</span><span \
class="n">itpoint</span><span class="p">.</span><span class="n">key</span><span \
class="p">()],</span> <span class="k">this</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead, use itpoint.value() instead</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105253#file105253line72" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/RenderPluginTest.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RenderPluginTest::restoreDefaultSettings_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">72</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">testName</span> \
<span class="o">=</span> <span class="n">QString</span><span class="p">(</span> <span \
class="s">"%1 %2"</span> <span class="p">).</span><span \
class="n">arg</span><span class="p">(</span> <span class="n">plugin</span><span \
class="o">-></span><span class="n">nameId</span><span class="p">()</span> <span \
class="p">).</span><span class="n">arg</span><span class="p">(</span> <span \
class="n">key</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">72</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QHash</span><span class="o"><</span><span class="n">QString</span><span \
class="p">,</span> <span class="n">QVariant</span><span class="o">>::</span><span \
class="n">const_iterator</span> <span class="n">itpoint</span> <span \
class="o">=</span> <span class="n">settings</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105253#file105253line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/RenderPluginTest.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RenderPluginTest::restoreDefaultSettings_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">73</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span> <span class="n">testName</span><span class="p">.</span><span \
class="n">toAscii</span><span class="p">()</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">result</span><span \
class="o">-></span><span class="n">settings</span><span class="p">().</span><span \
class="n">value</span><span class="p">(</span> <span class="n">key</span> <span \
class="p">)</span> <span class="o"><<</span> <span \
class="n">expected</span><span class="o">-></span><span \
class="n">settings</span><span class="p">().</span><span class="n">value</span><span \
class="p">(</span> <span class="n">key</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QHash</span><span class="o"><</span><span class="n">QString</span><span \
class="p">,</span> <span class="n">QVariant</span><span class="o">>::</span><span \
class="n">const_iterator</span> <span class="k">const</span> <span \
class="n">endpoint</span> <span class="o">=</span> <span \
class="n">settings</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105253#file105253line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/RenderPluginTest.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
RenderPluginTest::restoreDefaultSettings_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QTest</span><span class="o">::</span><span \
class="n">newRow</span><span class="p">(</span> <span class="n">testName</span><span \
class="p">.</span><span class="n">toAscii</span><span class="p">()</span> <span \
class="p">)</span> <span class="o"><<</span> <span class="n">result</span><span \
class="o">-></span><span class="n">settings</span><span class="p">().</span><span \
class="n">value</span><span class="p">(</span> <span class="n">itpoint</span><span \
class="p">.</span><span class="n">key</span><span class="p">()</span> <span \
class="p">)</span> <span class="o"><<</span> <span \
class="n">expected</span><span class="o">-></span><span \
class="n">settings</span><span class="p">().</span><span class="n">value</span><span \
class="p">(</span> <span class="n">itpoint</span><span class="p">.</span><span \
class="n">key</span><span class="p">()</span> <span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unneeded \
lookup overhead at expected->settings().value(), use itpoint.value() instead</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105254#file105254line205" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoDataWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoDataWriter::saveAndCompare()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">205</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">foreach</span></span><span class="hl"> </span><span class="p"><span \
class="hl">(</span></span><span class="k"><span class="hl">const</span></span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoDataParser</span><span class="o">></span> <span class="o"><span \
class="hl">&</span></span><span class="n"><span \
class="hl">parser</span></span><span class="p"><span class="hl">,</span></span> <span \
class="n">parsers</span><span class="p">.</span><span class="n"><span \
class="hl">values</span></span><span class="p"><span \
class="hl">())</span></span><span class="hl"> </span><span class="p"><span \
class="hl">{</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">203</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">QMap</span></span><span class="o"><span class="hl"><</span></span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">,</span></span> <span class="n">QSharedPointer</span><span \
class="o"><</span><span class="n">GeoDataParser</span><span class="o">></span> \
<span class="o"><span class="hl">>::</span></span><span class="n"><span \
class="hl">iterator</span></span><span class="hl"> </span><span class="n"><span \
class="hl">itpoint</span></span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span> <span class="n">parsers</span><span \
class="p">.</span><span class="n"><span class="hl">begin</span></span><span \
class="p"><span class="hl">();</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105254#file105254line206" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoDataWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoDataWriter::saveAndCompare()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">206</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">delete</span> <span class="n">parser</span><span \
class="o">-></span><span class="n">releaseDocument</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">204</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoDataParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">parsers</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line109" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::initTestCase()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">109</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">key</span><span \
class="p">,</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">keys</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">109</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="n">itpoint</span> \
<span class="o">=</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line110" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::initTestCase()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">110</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span> <span class="n">key</span><span class="p">.</span><span \
class="n">toLocal8Bit</span><span class="p">()</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span class="n">key</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">110</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">parsers</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line136" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">134</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">key</span><span \
class="p">,</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">keys</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">136</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="n">itpoint</span> \
<span class="o">=</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line137" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">135</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span> <span class="n">key</span><span class="p">.</span><span \
class="n">toLocal8Bit</span><span class="p">()</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span class="n">key</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">137</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">parsers</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line168" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::saveAndLoad()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">164</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">key</span><span \
class="p">,</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">keys</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">168</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="n">itpoint</span> \
<span class="o">=</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105255#file105255line169" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/TestGeoSceneWriter.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TestGeoSceneWriter::saveAndLoad()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">165</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span> <span class="n">key</span><span class="p">.</span><span \
class="n">toLocal8Bit</span><span class="p">()</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">parsers</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span class="n">key</span><span \
class="p">)</span> <span class="o"><<</span> <span class="n">key</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">169</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QSharedPointer</span><span class="o"><</span><span \
class="n">GeoSceneParser</span><span class="o">></span> <span \
class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> \
<span class="n">endpoint</span> <span class="o">=</span> <span \
class="n">parsers</span><span class="p">.</span><span class="n">end</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105256#file105256line239" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tools/osm-addresses/OsmParser.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OsmParser::read( const QFileInfo &content, const QString &areaName \
)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">239</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">foreach</span></span><span class="p"><span class="hl">(</span></span><span \
class="hl"> </span><span class="k"><span class="hl">const</span></span> <span \
class="n">Relation</span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">relation</span></span><span class="p"><span class="hl">,</span></span> \
<span class="n">m_relations</span><span class="p">.</span><span class="n"><span \
class="hl">values</span></span><span class="p"><span class="hl">()</span></span><span \
class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> \
</span><span class="p"><span class="hl">{</span></span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">239</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QHash</span></span><span class="o"><span \
class="hl"><</span></span><span class="kt"><span class="hl">int</span></span><span \
class="p"><span class="hl">,</span></span> <span class="n">Relation</span><span \
class="o"><span class="hl">>::</span></span><span class="n"><span \
class="hl">iterator</span></span><span class="hl"> </span><span class="n"><span \
class="hl">itpoint</span></span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span> <span class="n">m_relations</span><span \
class="p">.</span><span class="n"><span class="hl">begin</span></span><span \
class="p"><span class="hl">();</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constBegin</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108217/diff/4/?file=105256#file105256line240" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tools/osm-addresses/OsmParser.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
OsmParser::read( const QFileInfo &content, const QString &areaName \
)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">240</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span class="n">relation</span><span \
class="p">.</span><span class="n">isAdministrativeBoundary</span> <span \
class="cm">/*&& relation.isMultipolygon*/</span> <span class="p">)</span> \
<span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">240</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QHash</span><span \
class="o"><</span><span class="kt">int</span><span class="p">,</span> <span \
class="n">Relation</span><span class="o">>::</span><span class="n">iterator</span> \
<span class="k">const</span> <span class="n">endpoint</span> <span class="o">=</span> \
<span class="n">m_relations</span><span class="p">.</span><span \
class="n">end</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const_iterator, constEnd</pre> </div>
<br />
<p>- Kevin</p>
<br />
<p>On January 6th, 2013, 1:59 p.m., Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Marble and Kevin Krammer.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 1:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8159207
fixed Krazy issues on foreach loops</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/FileManager.cpp <span style="color: grey">(2bac816)</span></li>
<li>src/lib/StackedTileLoader.cpp <span style="color: grey">(962bfef)</span></li>
<li>src/lib/routing/RouteAnnotator.cpp <span style="color: \
grey">(bf5e6f7)</span></li>
<li>src/plugins/render/opencaching/OpenCachingModel.cpp <span style="color: \
grey">(e333168)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(ce6e5d1)</span></li>
<li>tests/RenderPluginTest.cpp <span style="color: grey">(f7dd2e3)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(a25ba95)</span></li>
<li>tests/TestGeoSceneWriter.cpp <span style="color: grey">(222e22f)</span></li>
<li>tools/osm-addresses/OsmParser.cpp <span style="color: \
grey">(1a24066)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108217/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic