[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Google Code-In: Marble Code Checker Issue Fixes
From: "Torsten Rahn" <tackat () kde ! org>
Date: 2012-12-27 19:20:40
Message-ID: 20121227192040.18933.79500 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107959/#review24068
-----------------------------------------------------------
In general it's good to resolve crazy checks. The "contrib" classes inside =
the mex directory (e.g. astrolib and planetSat classes) are maybe a bit of =
an exception: It's third party code that will later on be moved into a 3rdp=
arty/contrib directory. So making changes to the code in this particular ca=
se will probably not have a real benefit I'm afraid.
- Torsten Rahn
On Dec. 27, 2012, 7:01 p.m., Geoffrey Mon wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107959/
> -----------------------------------------------------------
> =
> (Updated Dec. 27, 2012, 7:01 p.m.)
> =
> =
> Review request for KDE Edu, Marble and Kevin Krammer.
> =
> =
> Description
> -------
> =
> For http://www.google-melange.com/gci/task/view/google/gci2012/8127209
> 31-40 code checker issues (http://www.englishbreakfastnetwork.org/krazy/r=
eports/kde-4.x/kdeedu/marble/index.html) fixed
> (mostly pre/postfix increment/decrement issues)
> =
> =
> Diffs
> -----
> =
> src/lib/NavigationWidget.cpp dbc2717 =
> src/plugins/render/satellites/mex/astrolib.cpp dbd1a86 =
> src/plugins/render/satellites/mex/attlib.cpp c9f5486 =
> src/plugins/render/satellites/mex/planetarySats.cpp d5dfe66 =
> =
> Diff: http://git.reviewboard.kde.org/r/107959/diff/
> =
> =
> Testing
> -------
> =
> None
> =
> =
> Thanks,
> =
> Geoffrey Mon
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107959/">http://git.reviewboard.kde.org/r/107959/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general it's good \
to resolve crazy checks. The "contrib" classes inside the mex directory \
(e.g. astrolib and planetSat classes) are maybe a bit of an exception: It's third \
party code that will later on be moved into a 3rdparty/contrib directory. So making \
changes to the code in this particular case will probably not have a real benefit \
I'm afraid.</pre> <br />
<p>- Torsten</p>
<br />
<p>On December 27th, 2012, 7:01 p.m., Geoffrey Mon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Marble and Kevin Krammer.</div>
<div>By Geoffrey Mon.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 7:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For http://www.google-melange.com/gci/task/view/google/gci2012/8127209 \
31-40 code checker issues \
(http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeedu/marble/index.html) \
fixed (mostly pre/postfix increment/decrement issues)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/NavigationWidget.cpp <span style="color: grey">(dbc2717)</span></li>
<li>src/plugins/render/satellites/mex/astrolib.cpp <span style="color: \
grey">(dbd1a86)</span></li>
<li>src/plugins/render/satellites/mex/attlib.cpp <span style="color: \
grey">(c9f5486)</span></li>
<li>src/plugins/render/satellites/mex/planetarySats.cpp <span style="color: \
grey">(d5dfe66)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107959/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic