'Re: Review Request: Fix Kalzium build with -DWITH_OpenBabel2=OFF'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Fix Kalzium build with -DWITH_OpenBabel2=OFF
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-07 6:45:58
Message-ID: 20121107064558.11086.42342 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107214/#review21523
-----------------------------------------------------------

This review has been submitted with commit \
ed08a7eb1914a8e3a51f1dbf84a524d33cd4a119 by Michael Palimaka to branch \
master.

- Commit Hook

On Nov. 5, 2012, 3:13 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107214/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 3:13 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Build with -DWITH_OpenBabel2=OFF fails:
> 
> CMake Error at KalziumConfigureChecks.cmake:9 (pkg_check_modules):
> Unknown CMake command "pkg_check_modules".
> Call Stack (most recent call first):
> CMakeLists.txt:31 (include)
> 
> Since pkg_check_modules is now used in the root cmake file, find_package \
> should be called there too. 
> 
> Diffs
> -----
> 
> KalziumConfigureChecks.cmake fe52526ed3664e24888e38d2dc6c52d90ca2be0c 
> 
> Diff: http://git.reviewboard.kde.org/r/107214/diff/
> 
> 
> Testing
> -------
> 
> Build is successful.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107214/">http://git.reviewboard.kde.org/r/107214/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
ed08a7eb1914a8e3a51f1dbf84a524d33cd4a119 by Michael Palimaka to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 5th, 2012, 3:13 p.m., Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated Nov. 5, 2012, 3:13 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build with -DWITH_OpenBabel2=OFF fails:

CMake Error at KalziumConfigureChecks.cmake:9 (pkg_check_modules):
  Unknown CMake command &quot;pkg_check_modules&quot;.
Call Stack (most recent call first):
  CMakeLists.txt:31 (include)

Since pkg_check_modules is now used in the root cmake file, find_package \
should be called there too. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build is successful.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>KalziumConfigureChecks.cmake <span style="color: \
grey">(fe52526ed3664e24888e38d2dc6c52d90ca2be0c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107214/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 