[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Hint at the right resolution
From:       "Commit Hook" <null () kde ! org>
Date:       2012-10-08 20:32:42
Message-ID: 20121008203242.26412.11099 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106659/#review20100
-----------------------------------------------------------


This review has been submitted with commit 593ff7f3462c64d32ae8b99b71b5ba44fab1597c \
by Jaime Torres to branch master.

- Commit Hook


On Oct. 8, 2012, 7:39 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106659/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 7:39 p.m.)
> 
> 
> Review request for KDE Edu and Anne-Marie Mahfouf.
> 
> 
> Description
> -------
> 
> Fix for the JJ: https://bugs.kde.org/show_bug.cgi?id=258155
> From Andreas <kainz.a@gmail.com>, that is still fighting with git (and has asked me \
> to push it for him) 
> 
> This addresses bug 28155.
> http://bugs.kde.org/show_bug.cgi?id=28155
> 
> 
> Diffs
> -----
> 
> src/desktop/khangmanview.cpp b6b748a 
> TODO 26ad5f1 
> 
> Diff: http://git.reviewboard.kde.org/r/106659/diff/
> 
> 
> Testing
> -------
> 
> I can read the hints now at full screen.
> 
> 
> Screenshots
> -----------
> 
> small fixed point
> http://git.reviewboard.kde.org/r/106659/s/761/
> big fixed point
> http://git.reviewboard.kde.org/r/106659/s/762/
> small proposed
> http://git.reviewboard.kde.org/r/106659/s/763/
> big proposed
> http://git.reviewboard.kde.org/r/106659/s/764/
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106659/">http://git.reviewboard.kde.org/r/106659/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 593ff7f3462c64d32ae8b99b71b5ba44fab1597c by Jaime Torres to \
branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On October 8th, 2012, 7:39 p.m., Jaime Torres Amate wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Anne-Marie Mahfouf.</div>
<div>By Jaime Torres Amate.</div>


<p style="color: grey;"><i>Updated Oct. 8, 2012, 7:39 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix for the JJ: https://bugs.kde.org/show_bug.cgi?id=258155 From Andreas \
&lt;kainz.a@gmail.com&gt;, that is still fighting with git (and has asked me to push \
it for him)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can read the hints now at full screen.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=28155">28155</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/desktop/khangmanview.cpp <span style="color: grey">(b6b748a)</span></li>

 <li>TODO <span style="color: grey">(26ad5f1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106659/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106659/s/761/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/khangman_small_400x100.png" \
style="border: 1px black solid;" alt="small fixed point" /></a>

 <a href="http://git.reviewboard.kde.org/r/106659/s/762/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/khangman_big_400x100.png" \
style="border: 1px black solid;" alt="big fixed point" /></a>

 <a href="http://git.reviewboard.kde.org/r/106659/s/763/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/khangman_small_proposed_400x100.png" \
style="border: 1px black solid;" alt="small proposed" /></a>

 <a href="http://git.reviewboard.kde.org/r/106659/s/764/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/khangman_big_proposed_400x100.png" \
style="border: 1px black solid;" alt="big proposed" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic