[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Drop unneeded linking target
From: Aleix Pol <aleixpol () kde ! org>
Date: 2012-10-02 22:07:02
Message-ID: CACcA1RrUQ6RPwzg1DqiKXRdhbetYpUi17dAOsQRK4AucNoLUuA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Oct 2, 2012 at 11:15 PM, Ben Cooksley <bcooksley@kde.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106696/
>
> On October 2nd, 2012, 8:49 p.m., *Aleix Pol Gonzalez* wrote:
>
> Great, thanks for looking into this!
>
> Maybe I could get notifications on problems in build.kde.org? or is there an RSS?
>
> On October 2nd, 2012, 9:04 p.m., *Albert Astals Cid* wrote:
>
> /me shows http://build.kde.org/job/kalgebra_master/ to Aleix
>
> On October 2nd, 2012, 9:09 p.m., *Ben Cooksley* wrote:
>
> I'll add that RSS feeds for both kdeedu as a group, and all projects on \
> build.kde.org are also available. See http://build.kde.org/view/kdeedu/ and \
> http://build.kde.org/ for more on those.
> In terms of email based notifications, that is a project-wide option - so making it \
> available is being delayed for now until the precise details are sorted out.
> When I tried to push this, it seems it had already been submitted in \
> 336f5004b611b4bef8b039f3b9876165e53908a7.
>
> - Ben
>
> On October 2nd, 2012, 7:58 p.m., Ben Cooksley wrote:
> Review request for KDE Edu.
> By Ben Cooksley.
>
> *Updated Oct. 2, 2012, 7:58 p.m.*
> Description
>
> KAlgebra does not seem to need QGLViewer in order to successfully compile - so \
> remove it from the link targets to make it easier to build.
> It seems changes somewhere (likely in latest CMake) cause the QGLVIEWER_LIBRARY \
> variable to be set to QGLVIEWER_LIBRARY-NOTFOUND now - instead of simply blank as \
> it previously was when nothing was found.
> Removing the ${QGLVIEWER_LIBRARY} fixes the build on build.kde.org.
>
> Testing
>
> Compiles without QGLViewer available.
>
> Diffs
>
> - src/CMakeLists.txt (7cbba68)
>
> View Diff <http://git.reviewboard.kde.org/r/106696/diff/>
>
That's from some days ago already... (21st september) and yes, I thought we
had removed all QGLViewer remainings. I think now it's all set.
Aleix
[Attachment #5 (text/html)]
On Tue, Oct 2, 2012 at 11:15 PM, Ben Cooksley <span dir="ltr"><<a \
href="mailto:bcooksley@kde.org" target="_blank">bcooksley@kde.org</a>></span> \
wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 \
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106696/" \
target="_blank">http://git.reviewboard.kde.org/r/106696/</a> </td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"><div class="im"> <p style="margin-top:0">On October 2nd, \
2012, 8:49 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p> </div><div \
class="im"><blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Great, \
thanks for looking into this!
Maybe I could get notifications on problems in <a href="http://build.kde.org" \
target="_blank">build.kde.org</a>? or is there an RSS?</pre> </blockquote>
</div><p>On October 2nd, 2012, 9:04 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">/me \
shows <a href="http://build.kde.org/job/kalgebra_master/" \
target="_blank">http://build.kde.org/job/kalgebra_master/</a> to Aleix</pre>
</blockquote><div class="im">
<p>On October 2nd, 2012, 9:09 p.m., <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'll \
add that RSS feeds for both kdeedu as a group, and all projects on <a \
href="http://build.kde.org" target="_blank">build.kde.org</a> are also available. See \
<a href="http://build.kde.org/view/kdeedu/" \
target="_blank">http://build.kde.org/view/kdeedu/</a> and <a \
href="http://build.kde.org/" target="_blank">http://build.kde.org/</a> for more on \
those.
In terms of email based notifications, that is a project-wide option - so making it \
available is being delayed for now until the precise details are sorted out.</pre> \
</blockquote>
</div></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">When \
I tried to push this, it seems it had already been submitted in \
336f5004b611b4bef8b039f3b9876165e53908a7.</pre>
<span class="HOEnZb"><font color="#888888">
<br>
<p>- Ben</p></font></span><div class="im">
<br>
<p>On October 2nd, 2012, 7:58 p.m., Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url('');background-repeat:repeat-x;border:1px black \
solid"> <tbody><tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Ben Cooksley.</div>
<p style="color:grey"><i>Updated Oct. 2, 2012, 7:58 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">KAlgebra \
does not seem to need QGLViewer in order to successfully compile - so remove it from \
the link targets to make it easier to build.
It seems changes somewhere (likely in latest CMake) cause the QGLVIEWER_LIBRARY \
variable to be set to QGLVIEWER_LIBRARY-NOTFOUND now - instead of simply blank as it \
previously was when nothing was found.
Removing the ${QGLVIEWER_LIBRARY} fixes the build on <a href="http://build.kde.org" \
target="_blank">build.kde.org</a>.</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Compiles \
without QGLViewer available.</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/CMakeLists.txt <span style="color:grey">(7cbba68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106696/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><div><br></div>That's from some days ago already... (21st \
september) and yes, I thought we had removed all QGLViewer remainings. I think now \
it's all set.<div><br></div><div>Aleix</div>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic