'Re: Review Request: Implement an explicit default constructor for the variables model'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Implement an explicit default constructor for the variables model
From:       "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date:       2012-09-24 14:11:47
Message-ID: 20120924141147.3188.69826 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106556/#review19386
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On Sept. 24, 2012, 2 p.m., Laszlo Papp wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106556/
> -----------------------------------------------------------
> =

> (Updated Sept. 24, 2012, 2 p.m.)
> =

> =

> Review request for KDE Edu and Aleix Pol Gonzalez.
> =

> =

> Description
> -------
> =

> There is the understanding with the change that the "m_vars" member varia=
ble is not filled in at registration time, so this should be done elsewhere=
 either by a mutator method or a default value. Perhaps this should be some=
thing else.
> =

> Either way, this is now making the building working which is needed for t=
he kdeedu package generation. Let me know if I can help with a better appro=
ach. We would not probably use this frontend on Windows 7, but one could sa=
y as the state of art, this could be run on Windows tablet for now. Thereby=
, the KDE Windows team would like to get it solved instead of explicitely d=
isabling. It is also a valid use case for the clients to have a registerabl=
e model on Windows as well.
> =

> =

> Diffs
> -----
> =

>   analitzagui/variablesmodel.h c5551de =

>   analitzagui/variablesmodel.cpp 681beb9 =

> =

> Diff: http://git.reviewboard.kde.org/r/106556/diff/
> =

> =

> Testing
> -------
> =

> Build and runtime test. Do not see outstanding issues cased by this so fa=
r, but it was a brief runtime test admittedly. :-)
> =

> =

> Thanks,
> =

> Laszlo Papp
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106556/">http://git.reviewboard.kde.org/r/106556/</a>
     </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix</p>

<br />
<p>On September 24th, 2012, 2 p.m., Laszlo Papp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Laszlo Papp.</div>

<p style="color: grey;"><i>Updated Sept. 24, 2012, 2 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is the understanding with the change \
that the &quot;m_vars&quot; member variable is not filled in at registration time, so this should be done \
elsewhere either by a mutator method or a default value. Perhaps this should be something else.

Either way, this is now making the building working which is needed for the kdeedu package generation. \
Let me know if I can help with a better approach. We would not probably use this frontend on Windows 7, \
but one could say as the state of art, this could be run on Windows tablet for now. Thereby, the KDE \
Windows team would like to get it solved instead of explicitely disabling. It is also a valid use case \
for the clients to have a registerable model on Windows as well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build and runtime test. Do not see \
outstanding issues cased by this so far, but it was a brief runtime test admittedly. :-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>analitzagui/variablesmodel.h <span style="color: grey">(c5551de)</span></li>

 <li>analitzagui/variablesmodel.cpp <span style="color: grey">(681beb9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106556/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 