[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Fix Cantor .desktop validation
From: "Commit Hook" <null () kde ! org>
Date: 2012-09-04 8:35:57
Message-ID: 20120904083557.23532.29741 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106216/#review18491
-----------------------------------------------------------
This review has been submitted with commit e6d2ce01d76b687446a54d2a20c9e667=
1ad72ef0 by Michael Palimaka to branch KDE/4.9.
- Commit Hook
On Aug. 26, 2012, 1:58 p.m., Michael Palimaka wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106216/
> -----------------------------------------------------------
> =
> (Updated Aug. 26, 2012, 1:58 p.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> Cantor fails .desktop validation:
> =
> src/cantor.desktop: error: (will be fatal in the future): value "Math" in=
key "Categories" in group "Desktop Entry" requires another category to be =
present among the following categories: Education;Science
> =
> This patch adds the missing category.
> =
> =
> Diffs
> -----
> =
> src/cantor.desktop 2d22b91cb6c31a0133304691f5f42c71a049e5c9 =
> =
> Diff: http://git.reviewboard.kde.org/r/106216/diff/
> =
> =
> Testing
> -------
> =
> Validation passes.
> =
> =
> Thanks,
> =
> Michael Palimaka
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106216/">http://git.reviewboard.kde.org/r/106216/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e6d2ce01d76b687446a54d2a20c9e6671ad72ef0 by Michael Palimaka to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 26th, 2012, 1:58 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cantor fails .desktop validation:
src/cantor.desktop: error: (will be fatal in the future): value "Math" in \
key "Categories" in group "Desktop Entry" requires another \
category to be present among the following categories: Education;Science
This patch adds the missing category.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Validation passes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/cantor.desktop <span style="color: \
grey">(2d22b91cb6c31a0133304691f5f42c71a049e5c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic