'Review Request: Fix potential Cantor parallel build issue'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request: Fix potential Cantor parallel build issue
From:       "Michael Palimaka" <kensington () gentoo ! org>
Date:       2012-07-31 12:53:19
Message-ID: 20120731125319.18114.58289 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105804/
-----------------------------------------------------------

Review request for KDE Edu.

Description
-------

It was reported downstream that it may be possible for Cantor to fail a par=
allel build:

src/backends/qalculate/plotassistant/qalculateplotassistant.h:37:11: error:=
 'QalculateSettings' was not declared in this scope

Investigation points towards an error in the build dependency tree. cantor_=
qalculateplotassistant depends on ../settings.kcfgc which produces ./settin=
gs.h, but ../settings.h from some other target is referenced (in qalculatep=
lotassistant.h).

This patch just changes this to use the settings.h generated by the correct=
 target.

Diffs
-----

  src/backends/qalculate/plotassistant/qalculateplotassistant.h ac55b51cd67=
c1c403f28ca99eb72390a2f03a834 =

Diff: http://git.reviewboard.kde.org/r/105804/diff/

Testing
-------

The contents of both settings.h files are the same.
Build is normal, and settings.h is now correctly regenerated when expectant=
ly missing.

Thanks,

Michael Palimaka

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105804/">http://git.reviewboard.kde.org/r/105804/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Michael Palimaka.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It was reported downstream that it may be possible for Cantor to fail a \
parallel build:

src/backends/qalculate/plotassistant/qalculateplotassistant.h:37:11: error: \
&#39;QalculateSettings&#39; was not declared in this scope

Investigation points towards an error in the build dependency tree. \
cantor_qalculateplotassistant depends on ../settings.kcfgc which produces \
./settings.h, but ../settings.h from some other target is referenced (in \
qalculateplotassistant.h).

This patch just changes this to use the settings.h generated by the correct \
target.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The contents of both settings.h files are the same. Build is normal, and \
settings.h is now correctly regenerated when expectantly missing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/qalculate/plotassistant/qalculateplotassistant.h <span \
style="color: grey">(ac55b51cd67c1c403f28ca99eb72390a2f03a834)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105804/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 