From kde-edu-devel Thu Jul 19 21:05:12 2012 From: "Albert Astals Cid" Date: Thu, 19 Jul 2012 21:05:12 +0000 To: kde-edu-devel Subject: Re: Review Request: Set Antialiasing in Kig Message-Id: <20120719210512.12470.22267 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=134273218304377 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3479200762196534400==" --===============3479200762196534400== Content-Type: multipart/alternative; boundary="===============1844228583910722650==" --===============1844228583910722650== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 15, 2012, 10:26 p.m., Albert Astals Cid wrote: > > To be honest i'm not sure i like the antialiased variants more, but on = the other hand, i'm not a user of kig so not sure you should be listening t= o me :D > = > David Narv=C3=A1ez wrote: > I actually have no preference over one or the other. Maybe add a conf= iguration checkbox to use antialiasing? Ping? I don't think a configuration is the best of the ideas, maybe a hidde= n one? E.g. something that is documented in the manual but not exposed in t= he gui? Noone else has an opinion? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104584/#review12491 ----------------------------------------------------------- On April 15, 2012, 5:26 p.m., David Narv=C3=A1ez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104584/ > ----------------------------------------------------------- > = > (Updated April 15, 2012, 5:26 p.m.) > = > = > Review request for KDE Edu. > = > = > Description > ------- > = > Pretty straightforward, the question is actually if anybody disagrees. Th= e one issue I would be concerned about is performance, but I would expect t= his not to be an issue in modern computers, yet I don't have any stress cas= e to test this against. > = > = > This addresses bug 122376. > http://bugs.kde.org/show_bug.cgi?id=3D122376 > = > = > Diffs > ----- > = > misc/kigpainter.cpp 18d4396 = > = > Diff: http://git.reviewboard.kde.org/r/104584/diff/ > = > = > Testing > ------- > = > Compare drawing a large circle with and without this patch to see antiali= asing in action. > = > = > Screenshots > ----------- > = > Antialiased > http://git.reviewboard.kde.org/r/104584/s/535/ > Aliased > http://git.reviewboard.kde.org/r/104584/s/536/ > Antialiased Heptagonal Tessellation > http://git.reviewboard.kde.org/r/104584/s/539/ > Aliased Heptagonal Tessellation > http://git.reviewboard.kde.org/r/104584/s/540/ > = > = > Thanks, > = > David Narv=C3=A1ez > = > --===============1844228583910722650== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104584/

On April 15th, 2012, 10:26 p.m., Albert Ast= als Cid wrote:

To be hon=
est i'm not sure i like the antialiased variants more, but on the other=
 hand, i'm not a user of kig so not sure you should be listening to me =
:D

On April 19th, 2012, 5:28 a.m., David Narv=C3=A1ez wrote:

I actuall=
y have no preference over one or the other. Maybe add a configuration check=
box to use antialiasing?
Ping? I don=
't think a configuration is the best of the ideas, maybe a hidden one? =
E.g. something that is documented in the manual but not exposed in the gui?=
 Noone else has an opinion?

- Albert


On April 15th, 2012, 5:26 p.m., David Narv=C3=A1ez wrote:

Review request for KDE Edu.
By David Narv=C3=A1ez.

Updated April 15, 2012, 5:26 p.m.

Descripti= on 

Pretty straightforward, the question is actually if anybody =
disagrees. The one issue I would be concerned about is performance, but I w=
ould expect this not to be an issue in modern computers, yet I don't ha=
ve any stress case to test this against.

Testing <= /h1> 
Compare drawing a large circle with and without this patch t=
o see antialiasing in action.
Bugs: 122376

Diffs=

  • misc/kigpainter.cpp (18d4396)

View Diff

Screensho= ts

3D"Antia= 3D"Aliased" =3D"Aliased
--===============1844228583910722650==-- --===============3479200762196534400== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============3479200762196534400==--