[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Make 'show bookmarks' menu option settings to be persistent through restarts (Qt
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-11 12:51:20
Message-ID: 20120311125120.14699.85554 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104224/#review11283
-----------------------------------------------------------
This review has been submitted with commit fb6d3caf0a38214e52be74c3edebdff1=
909ca851 by Dennis Nienh=C3=BCser to branch master.
- Commit Hook
On March 11, 2012, 12:04 p.m., Khanh-Nhan Nguyen wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104224/
> -----------------------------------------------------------
> =
> (Updated March 11, 2012, 12:04 p.m.)
> =
> =
> Review request for KDE Edu and Marble.
> =
> =
> Description
> -------
> =
> Make 'show bookmarks' menu option settings to be persistent through resta=
rts.
> --Qt version only, still need to copy this feature to KDE version.
> =
> =
> Diffs
> -----
> =
> src/QtMainWindow.h 5ef6600 =
> src/QtMainWindow.cpp 9ce339f =
> =
> Diff: http://git.reviewboard.kde.org/r/104224/diff/
> =
> =
> Testing
> -------
> =
> - Work as expected: after restarting marble, the 'show bookmarks' menu en=
try keeps the same settings as when it's last closed.
> - When launched with 'show bookmarks' option initially off, the bookmarks=
do not appear on the map.
> =
> =
> Thanks,
> =
> Khanh-Nhan Nguyen
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104224/">http://git.reviewboard.kde.org/r/104224/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fb6d3caf0a38214e52be74c3edebdff1909ca851 by Dennis Nienhüser \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 11th, 2012, 12:04 p.m., Khanh-Nhan Nguyen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Marble.</div>
<div>By Khanh-Nhan Nguyen.</div>
<p style="color: grey;"><i>Updated March 11, 2012, 12:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make 'show bookmarks' menu option settings to be persistent \
through restarts.
--Qt version only, still need to copy this feature to KDE version.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Work as expected: after restarting marble, the 'show \
bookmarks' menu entry keeps the same settings as when it's \
last closed.
- When launched with 'show bookmarks' option initially off, the bookmarks do \
not appear on the map.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.h <span style="color: grey">(5ef6600)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(9ce339f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic