[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Request to review this patch submit which fixes the bug #152182
From: "Anne-Marie Mahfouf" <annma () kde ! org>
Date: 2012-03-02 10:00:03
Message-ID: 20120302100003.28706.71451 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104138/#review11077
-----------------------------------------------------------
I am not satisfied with the patch.
1) In the View class we already have 2 methods [void sliderWindowClosed(); and void \
slidersWindowClosed();] for setting the m_menuSliderAction to false. So instead of \
adding a new method this should be fixed here. And see why there are 2 such methods. \
2) Is there a need for a toggle action as the dialog is either shown or not (doesn't \
it behave exactly as the Coordinate System dialog?) I would make it a simple action \
"Show Sliders..." to open the dialog. 3) As I said in the mail when we discussed this \
bug, the sliders behavior should be clarified. According to \
http://userbase.kde.org/KmPlot/Using_Sliders the sliders modify a parameter value. If \
there is no parameter, the dialog does nothing, as does nothing checking "Slider 1" \
in the tab. So should this be available at all in those cases?
I'll bring these points to the mailing list in order to discuss it here.
- Anne-Marie Mahfouf
On March 1, 2012, 10:23 p.m., Rahul Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104138/
> -----------------------------------------------------------
>
> (Updated March 1, 2012, 10:23 p.m.)
>
>
> Review request for KDE Edu, Burkhard Lück and Klaus-Dieter Möller.
>
>
> Description
> -------
>
> Attached two .diff files (patches) which fixes the bug.
>
>
> This addresses bug 152182.
> http://bugs.kde.org/show_bug.cgi?id=152182
>
>
> Diffs
> -----
>
>
> Diff: http://git.reviewboard.kde.org/r/104138/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul Sharma
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104138/">http://git.reviewboard.kde.org/r/104138/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not satisfied with \
the patch.
1) In the View class we already have 2 methods [void sliderWindowClosed(); and void \
slidersWindowClosed();] for setting the m_menuSliderAction to false. So instead of \
adding a new method this should be fixed here. And see why there are 2 such methods. \
2) Is there a need for a toggle action as the dialog is either shown or not \
(doesn't it behave exactly as the Coordinate System dialog?) I would make it a \
simple action "Show Sliders..." to open the dialog. 3) As I said in the \
mail when we discussed this bug, the sliders behavior should be clarified. According \
to http://userbase.kde.org/KmPlot/Using_Sliders the sliders modify a parameter value. \
If there is no parameter, the dialog does nothing, as does nothing checking \
"Slider 1" in the tab. So should this be available at all in those cases?
I'll bring these points to the mailing list in order to discuss it here.</pre>
<br />
<p>- Anne-Marie</p>
<br />
<p>On March 1st, 2012, 10:23 p.m., Rahul Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Burkhard Lück and Klaus-Dieter Möller.</div>
<div>By Rahul Sharma.</div>
<p style="color: grey;"><i>Updated March 1, 2012, 10:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attached two .diff files (patches) which fixes the bug.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=152182">152182</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104138/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic