[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Fix some bugs in parley
From: "Commit Hook" <null () kde ! org>
Date: 2012-01-05 16:19:41
Message-ID: 20120105161941.13334.82328 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103359/#review9575
-----------------------------------------------------------
This review has been submitted with commit 1aee5c4cee993ebd5d7530f6988184ca=
af7b8e98 by Jan Gerrit Marker to branch master.
- Commit Hook
On Jan. 5, 2012, 2:19 a.m., Jan Gerrit Marker wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103359/
> -----------------------------------------------------------
> =
> (Updated Jan. 5, 2012, 2:19 a.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> * Under some circumstances (close Parley when the welcome screen is opene=
d and start it with a file to open (parley <filename>)) the toolbar of the =
editor mode is not shown. This patch cleans up that code (removes m_hiddenT=
oolbars in ParleyMainwindow as it is not needed) and fixes the visibility o=
f the toolbar.
> * Pressing enter in the last line of the vocabulary table does create a n=
ew line but does not edit the new line.
> * Parley crashes when a new document is opened via "Open Recent" or "Open=
".
> =
> I searched the open Parley bug reports on bugs.kde.org for these issues b=
ut I did not find any report.
> =
> =
> Diffs
> -----
> =
> src/parleymainwindow.cpp 4ec0526 =
> src/vocabulary/vocabularyview.cpp 84d91c0 =
> src/editor/editor.cpp 243eb70 =
> src/parleymainwindow.h 48e6d1a =
> =
> Diff: http://git.reviewboard.kde.org/r/103359/diff/diff
> =
> =
> Testing
> -------
> =
> Fixes all bugs properly for me.
> =
> =
> Thanks,
> =
> Jan Gerrit Marker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103359/">http://git.reviewboard.kde.org/r/103359/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1aee5c4cee993ebd5d7530f6988184caaf7b8e98 by Jan Gerrit Marker \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 5th, 2012, 2:19 a.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2012, 2:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Under some circumstances (close Parley when the welcome screen is \
opened and start it with a file to open (parley <filename>)) the toolbar of the \
editor mode is not shown. This patch cleans up that code (removes m_hiddenToolbars in \
ParleyMainwindow as it is not needed) and fixes the visibility of the \
toolbar.
* Pressing enter in the last line of the vocabulary table does create a new line but \
does not edit the new line.
* Parley crashes when a new document is opened via "Open Recent" or \
"Open".
I searched the open Parley bug reports on bugs.kde.org for these issues but I did not \
find any report.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes all bugs properly for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/parleymainwindow.cpp <span style="color: grey">(4ec0526)</span></li>
<li>src/vocabulary/vocabularyview.cpp <span style="color: \
grey">(84d91c0)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(243eb70)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(48e6d1a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103359/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic