[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Finish the declension editing support of parley's
From: "Jan Gerrit Marker" <jangerrit () weiler-marker ! com>
Date: 2011-12-06 22:03:22
Message-ID: 20111206220322.22580.59039 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 6, 2011, 3:30 p.m., Frederik Gladhorn wrote:
> > Hi Jan Gerrit,
> > thanks for your work by the way!!!
> > I'm sorry that I'm not more responsive reviewing things.
> > What kept me from actually finishing the declension work back than was =
that I found the ui/practice mode for conjugation so broken that I wanted t=
o polish that before adding another half done feature.
> > I think it's great if you work on this though :)
> > Maybe we should discuss where you are heading with this work some time.
> > =
> > Cheers
> > Frederik
What does bother you about the conjugation ui? Maybe I can fix it before st=
arting the declension practice mode. By the way, I've got two bug fixes for=
parley I'll post tomorrow.
I'm not sure whether I understand your statement "Maybe we should discuss w=
here you are heading with this work some time." correctly. Do you mean a ge=
neral discussion about the declension practice mode?
Thanks for your general positive feedback :-)
- Jan Gerrit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103331/#review8758
-----------------------------------------------------------
On Dec. 6, 2011, 9:45 p.m., Jan Gerrit Marker wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103331/
> -----------------------------------------------------------
> =
> (Updated Dec. 6, 2011, 9:45 p.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> This patch continues the work done by Frederik Gladhorn on declension edi=
ting. Depending on review 103325 which extends libkdeedu's support for decl=
ensions this patch allows to edit the declensions of nouns and adjectives. =
As conjugations and declensions are both inflections and a word can only ha=
ve one of them (as far as I know from Latin, German and English and the Ger=
man Wikipedia articles) I merged them into one dock, called "Inflection". T=
he geometry of some buttons is not that nice but I'd like to get comments o=
n this first and polish it afterwards.
> =
> There's currently no practice mode but I plan to add it in the near futur=
e.
> =
> =
> Diffs
> -----
> =
> src/editor/editor.h 3362211 =
> src/editor/editor.cpp 243eb70 =
> src/editor/editorui.rc 28230818 =
> src/editor/inflectionwidget.h PRE-CREATION =
> src/editor/inflectionwidget.cpp PRE-CREATION =
> src/editor/declensionwidget.ui 9c31a40 =
> src/editor/declensionwidget.h 71e16c7 =
> src/editor/declensionwidget.cpp dbe4a05 =
> src/editor/conjugationwidget.cpp f3b1702 =
> src/editor/conjugationwidget.ui cff5ebf =
> src/CMakeLists.txt d219687 =
> src/editor/conjugationwidget.h 11cd937 =
> =
> Diff: http://git.reviewboard.kde.org/r/103331/diff/diff
> =
> =
> Testing
> -------
> =
> Works for me.
> =
> =
> Screenshots
> -----------
> =
> Declension: noun
> http://git.reviewboard.kde.org/r/103331/s/351/
> Declension: adjective
> http://git.reviewboard.kde.org/r/103331/s/352/
> New button layout and new title
> http://git.reviewboard.kde.org/r/103331/s/354/
> Conjugation
> http://git.reviewboard.kde.org/r/103331/s/355/
> =
> =
> Thanks,
> =
> Jan Gerrit Marker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103331/">http://git.reviewboard.kde.org/r/103331/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 6th, 2011, 3:30 p.m., <b>Frederik \
Gladhorn</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi Jan Gerrit, thanks for your work by the way!!!
I'm sorry that I'm not more responsive reviewing things.
What kept me from actually finishing the declension work back than was that I found \
the ui/practice mode for conjugation so broken that I wanted to polish that before \
adding another half done feature. I think it's great if you work on this though \
:) Maybe we should discuss where you are heading with this work some time.
Cheers
Frederik</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What does bother you \
about the conjugation ui? Maybe I can fix it before starting the declension practice \
mode. By the way, I've got two bug fixes for parley I'll post tomorrow.
I'm not sure whether I understand your statement "Maybe we should discuss \
where you are heading with this work some time." correctly. Do you mean a \
general discussion about the declension practice mode?
Thanks for your general positive feedback :-)</pre>
<br />
<p>- Jan Gerrit</p>
<br />
<p>On December 6th, 2011, 9:45 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2011, 9:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch continues the work done by Frederik Gladhorn on declension \
editing. Depending on review 103325 which extends libkdeedu's support for \
declensions this patch allows to edit the declensions of nouns and adjectives. As \
conjugations and declensions are both inflections and a word can only have one of \
them (as far as I know from Latin, German and English and the German Wikipedia \
articles) I merged them into one dock, called "Inflection". The geometry of \
some buttons is not that nice but I'd like to get comments on this first and \
polish it afterwards.
There's currently no practice mode but I plan to add it in the near future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.h <span style="color: grey">(3362211)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(243eb70)</span></li>
<li>src/editor/editorui.rc <span style="color: grey">(28230818)</span></li>
<li>src/editor/inflectionwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/inflectionwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/declensionwidget.ui <span style="color: grey">(9c31a40)</span></li>
<li>src/editor/declensionwidget.h <span style="color: grey">(71e16c7)</span></li>
<li>src/editor/declensionwidget.cpp <span style="color: grey">(dbe4a05)</span></li>
<li>src/editor/conjugationwidget.cpp <span style="color: grey">(f3b1702)</span></li>
<li>src/editor/conjugationwidget.ui <span style="color: grey">(cff5ebf)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(d219687)</span></li>
<li>src/editor/conjugationwidget.h <span style="color: grey">(11cd937)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103331/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103331/s/351/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/04/declension-noun_400x100.png" \
style="border: 1px black solid;" alt="Declension: noun" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/352/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/04/declension-adjective_400x100.png" \
style="border: 1px black solid;" alt="Declension: adjective" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/354/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/06/inflection-buttons_1_400x100.png" \
style="border: 1px black solid;" alt="New button layout and new title" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/355/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/06/conjugation-verb_400x100.png" \
style="border: 1px black solid;" alt="Conjugation" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic