'Re: Review Request: Save declensions gender specific'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Save declensions gender specific
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-06 21:14:30
Message-ID: 20111206211430.19410.36461 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103325/#review8770
-----------------------------------------------------------

This review has been submitted with commit 8528fcbfdc711d097fa3b27ef3c8974e=
6a96f5fb by Jan Gerrit Marker to branch master.

- Commit Hook

On Dec. 4, 2011, 1:50 p.m., Jan Gerrit Marker wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103325/
> -----------------------------------------------------------
> =

> (Updated Dec. 4, 2011, 1:50 p.m.)
> =

> =

> Review request for KDE Edu.
> =

> =

> Description
> -------
> =

> Some languages (Latin, for example) have declensions for adjectives which=
 do not only depend on the number and case but on the gender, too. libkdeed=
u has an implementation for declensions which does not honor this. This pat=
ch corrects that wrong behavior. The change adds an incompatibility to file=
s which were created using the old library. I don't think that there are a =
lot of files with declensions out there, as for example parley does not hav=
e the feature, yet, but if needed I'd try parse old files, too.
> =

> =

> Diffs
> -----
> =

>   keduvocdocument/keduvocdeclension.cpp 327c3ed =

> =

> Diff: http://git.reviewboard.kde.org/r/103325/diff/diff
> =

> =

> Testing
> -------
> =

> Works with parley, after finishing the implementation of the declension w=
idget (I'll create another review request in order to get this in).
> =

> =

> Thanks,
> =

> Jan Gerrit Marker
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103325/">http://git.reviewboard.kde.org/r/103325/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8528fcbfdc711d097fa3b27ef3c8974e6a96f5fb by Jan Gerrit Marker \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 4th, 2011, 1:50 p.m., Jan Gerrit Marker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>

<p style="color: grey;"><i>Updated Dec. 4, 2011, 1:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some languages (Latin, for example) have declensions for adjectives \
which do not only depend on the number and case but on the gender, too. libkdeedu has \
an implementation for declensions which does not honor this. This patch corrects that \
wrong behavior. The change adds an incompatibility to files which were created using \
the old library. I don&#39;t think that there are a lot of files with declensions out \
there, as for example parley does not have the feature, yet, but if needed I&#39;d \
try parse old files, too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works with parley, after finishing the implementation of the declension \
widget (I&#39;ll create another review request in order to get this in).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>keduvocdocument/keduvocdeclension.cpp <span style="color: \
grey">(327c3ed)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103325/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 