[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Fix Kalzium build and cleanup CMake warnings
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2011-11-23 7:48:25
Message-ID: 20111123074825.23596.18534 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103209/#review8407
-----------------------------------------------------------
This is not the right fix for your problems. It seems like there's a bug in=
avogadro's cmake-config file, possibly avogadro uses FindQt4 with the QT_U=
SE_IMPORTED_TARGETS flag set and then it generates the config-file with an =
'avogadro' target that has QtOpenGL in its link-interface. This causes a ta=
rget to be created for that and exported. But kalzium does not call FindQt4=
itself explicitly and hence does not set the QT_USE_IMPORTED_TARGETS. This=
causes cmake to not know that the QtOpenGL lib is an external lib.
In addition the cmake-config file from avogadro should put the imported tar=
get into a cmake variable and name it differently from the actual target in=
the avogadro build.
- Andreas Pakulat
On Nov. 23, 2011, 4:19 a.m., Ben Cooksley wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103209/
> -----------------------------------------------------------
> =
> (Updated Nov. 23, 2011, 4:19 a.m.)
> =
> =
> Review request for Build System and KDE Edu.
> =
> =
> Description
> -------
> =
> Currently I cannot build Kalzium, due to the following error message:
> gmake[2]: *** No rule to make target `/usr/lib64/libQtOpenGL.so', needed =
by `lib/libcompoundviewer.so.4.7.0'. Stop.
> =
> Combined with some warning output when CMake is run on Kalzium, I determi=
ned that the dynamic location of libraries, as is currently done for Avogad=
ro is problematic.
> =
> The patch changes this behaviour so that the path to Avogadro is supplied=
explicitly.
> It also fixes a linking issue with my system, where Kalzium refuses to li=
nk to QtOpenGL as it is not explicitly defined as a dependency.
> =
> =
> Diffs
> -----
> =
> KalziumConfigureChecks.cmake cef3d45 =
> compoundviewer/CMakeLists.txt b2b7e6c =
> src/CMakeLists.txt 47ebbd1 =
> =
> Diff: http://git.reviewboard.kde.org/r/103209/diff/diff
> =
> =
> Testing
> -------
> =
> Now compiles.
> =
> =
> Thanks,
> =
> Ben Cooksley
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103209/">http://git.reviewboard.kde.org/r/103209/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not the right \
fix for your problems. It seems like there's a bug in avogadro's cmake-config \
file, possibly avogadro uses FindQt4 with the QT_USE_IMPORTED_TARGETS flag set and \
then it generates the config-file with an 'avogadro' target that has QtOpenGL \
in its link-interface. This causes a target to be created for that and exported. But \
kalzium does not call FindQt4 itself explicitly and hence does not set the \
QT_USE_IMPORTED_TARGETS. This causes cmake to not know that the QtOpenGL lib is an \
external lib.
In addition the cmake-config file from avogadro should put the imported target into a \
cmake variable and name it differently from the actual target in the avogadro \
build.</pre> <br />
<p>- Andreas</p>
<br />
<p>On November 23rd, 2011, 4:19 a.m., Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and KDE Edu.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2011, 4:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently I cannot build Kalzium, due to the following error message: \
gmake[2]: *** No rule to make target `/usr/lib64/libQtOpenGL.so', needed by \
`lib/libcompoundviewer.so.4.7.0'. Stop.
Combined with some warning output when CMake is run on Kalzium, I determined that the \
dynamic location of libraries, as is currently done for Avogadro is problematic.
The patch changes this behaviour so that the path to Avogadro is supplied explicitly.
It also fixes a linking issue with my system, where Kalzium refuses to link to \
QtOpenGL as it is not explicitly defined as a dependency.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now compiles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KalziumConfigureChecks.cmake <span style="color: grey">(cef3d45)</span></li>
<li>compoundviewer/CMakeLists.txt <span style="color: grey">(b2b7e6c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(47ebbd1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103209/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic