[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: [Step] Fix "Fit to page" bug to work when world
From: "Commit Hook" <null () kde ! org>
Date: 2011-10-28 12:49:17
Message-ID: 20111028124917.4156.68027 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102940/#review7719
-----------------------------------------------------------
This review has been submitted with commit ca22407fd82db6abc79aae5266189c9d=
ce0c53ca by Shlomo Zaks to branch KDE/4.7.
- Commit Hook
On Oct. 25, 2011, 7:21 p.m., Shlomo Zaks wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102940/
> -----------------------------------------------------------
> =
> (Updated Oct. 25, 2011, 7:21 p.m.)
> =
> =
> Review request for KDE Edu and Patrick Spendrin.
> =
> =
> Description
> -------
> =
> In the current version, If you select the "Fit to page" option from the
> "View" menu when the world is empty (no objects), it jumps to the
> upper-left corner and sets the zoom incorrectly.
> This patch fixes it.
> =
> =
> Diffs
> -----
> =
> step/worldscene.cc d8d5265 =
> =
> Diff: http://git.reviewboard.kde.org/r/102940/diff/diff
> =
> =
> Testing
> -------
> =
> Testing: open Step, and select "View > Fit to page".
> Works fine after the fix
> =
> =
> Thanks,
> =
> Shlomo Zaks
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102940/">http://git.reviewboard.kde.org/r/102940/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ca22407fd82db6abc79aae5266189c9dce0c53ca by Shlomo Zaks to \
branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 25th, 2011, 7:21 p.m., Shlomo Zaks wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Patrick Spendrin.</div>
<div>By Shlomo Zaks.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2011, 7:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the current version, If you select the "Fit to page" option \
from the "View" menu when the world is empty (no objects), it jumps to the
upper-left corner and sets the zoom incorrectly.
This patch fixes it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing: open Step, and select "View > Fit to page". Works \
fine after the fix</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>step/worldscene.cc <span style="color: grey">(d8d5265)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102940/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic