[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Fix detection of kalgebra
From: "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date: 2011-10-19 2:23:49
Message-ID: 20111019022349.21617.65890 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102913/#review7482
-----------------------------------------------------------
Actually FindAnalitza.cmake should be moved to kdelibs I'd say, I'm not sure.
The rest is fine, thanks for taking your time and looking into it!
- Aleix Pol Gonzalez
On Oct. 19, 2011, 12:32 a.m., José Manuel Santamaría Lema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102913/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2011, 12:32 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> This patch alows one to build the kalgebra cantor backend when building kalgebra and cantor separately.
>
>
> This addresses bug 273974.
> http://bugs.kde.org/show_bug.cgi?id=273974
>
>
> Diffs
> -----
>
> CMakeLists.txt 743d739
> cmake/FindAnalitza.cmake e69de29
> src/backends/CMakeLists.txt 0664f07
> src/backends/kalgebra/CMakeLists.txt da39e3f
>
> Diff: http://git.reviewboard.kde.org/r/102913/diff/diff
>
>
> Testing
> -------
>
> I have just built that backend from the Debian packages we are developing.
>
>
> Thanks,
>
> José Manuel Santamaría Lema
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102913/">http://git.reviewboard.kde.org/r/102913/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Actually FindAnalitza.cmake should be moved to kdelibs I'd say, \
I'm not sure.
The rest is fine, thanks for taking your time and looking into it!</pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 19th, 2011, 12:32 a.m., José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2011, 12:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch alows one to build the kalgebra \
cantor backend when building kalgebra and cantor separately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have just built that backend from the \
Debian packages we are developing.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=273974">273974</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(743d739)</span></li>
<li>cmake/FindAnalitza.cmake <span style="color: grey">(e69de29)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(0664f07)</span></li>
<li>src/backends/kalgebra/CMakeLists.txt <span style="color: grey">(da39e3f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102913/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic