'Re: Review Request: Avoid processing parameters if the number of'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request: Avoid processing parameters if the number of
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2011-09-29 4:00:09
Message-ID: 20110929040009.18794.32661 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102725/
-----------------------------------------------------------

(Updated Sept. 29, 2011, 4 a.m.)

Review request for KDE Edu.

Changes
-------

After testing the patch without renaming the accept slot I realized the naming was \
actually doing the fix, so I had to pretty much redo the whole patch. This version \
achieves the same (blocking acceptance of the dialog until the arguments are all \
set).

Description
-------

Changed the finished variable to finish, as I think is the way the code was intended \
to be. Also fixes the second validation that took place (calling canFinish in the \
finishPressed method) since first validation happens in the validatePage method of \
the Arguments page.

This addresses bug 282913.
    http://bugs.kde.org/show_bug.cgi?id=282913

Diffs (updated)
-----

  modes/label.cc d0c855d 
  modes/textlabelwizard.cc 0721227 

Diff: http://git.reviewboard.kde.org/r/102725/diff/diff

Testing
-------

1) Created a new label
2) Introduced a parameter %1
3) Clicked Next
4) Clicked Finish without specifying a parameter
5) Clicked Ok in the error popup

No crash, no second validation.

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102725/">http://git.reviewboard.kde.org/r/102725/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2011, 4 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After testing the patch without renaming the accept slot I realized the \
naming was actually doing the fix, so I had to pretty much redo the whole patch. This \
version achieves the same (blocking acceptance of the dialog until the arguments are \
all set).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed the finished variable to finish, as I think is the way the code \
was intended to be. Also fixes the second validation that took place (calling \
canFinish in the finishPressed method) since first validation happens in the \
validatePage method of the Arguments page.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Created a new label 2) Introduced a parameter %1
3) Clicked Next
4) Clicked Finish without specifying a parameter
5) Clicked Ok in the error popup

No crash, no second validation.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=282913">282913</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>modes/label.cc <span style="color: grey">(d0c855d)</span></li>

 <li>modes/textlabelwizard.cc <span style="color: grey">(0721227)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102725/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 