[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: correct confusing action names in kanagrams
From: "Jeremy Paul Whiting" <jpwhiting () kde ! org>
Date: 2011-06-03 13:20:38
Message-ID: 20110603132038.10767.49538 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101496/#review3650
-----------------------------------------------------------
Ship it!
Looks good to me. Thanks for fixing this.
- Jeremy Paul
On June 3, 2011, 7 a.m., Burkhard L=C3=BCck wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101496/
> -----------------------------------------------------------
> =
> (Updated June 3, 2011, 7 a.m.)
> =
> =
> Review request for KDE Edu and Jeremy Paul Whiting.
> =
> =
> Summary
> -------
> =
> Kanagram has KStandardAction::prior (Qt::Key_PageUp) and next (Qt::Key_Pa=
geDown) for the actions to switch to the previous/next Vocabulary. But due =
to using KStandardAction::prior() and KStandardAction::next() these actions=
are labelled "Previous Page" and "Next Page" in the shortcuts dialog.
> Patch renames them to "Previous Vocabulary" and "Next Vocabulary" to make=
it clear, which action are handled with these shortcuts.
> =
> =
> Diffs
> -----
> =
> src/kanagram.cpp 97e1e90 =
> =
> Diff: http://git.reviewboard.kde.org/r/101496/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Burkhard
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101496/">http://git.reviewboard.kde.org/r/101496/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me. \
Thanks for fixing this.</pre> <br />
<p>- Jeremy Paul</p>
<br />
<p>On June 3rd, 2011, 7 a.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Jeremy Paul Whiting.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated June 3, 2011, 7 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kanagram has KStandardAction::prior (Qt::Key_PageUp) and next \
(Qt::Key_PageDown) for the actions to switch to the previous/next Vocabulary. But due \
to using KStandardAction::prior() and KStandardAction::next() these actions are \
labelled "Previous Page" and "Next Page" in the shortcuts dialog. \
Patch renames them to "Previous Vocabulary" and "Next Vocabulary" \
to make it clear, which action are handled with these shortcuts.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kanagram.cpp <span style="color: grey">(97e1e90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101496/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic