[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: Re: Review Request: KTouch: Bulgarian keyboard layout
From:       "Anne-Marie Mahfouf" <annemarie.mahfouf () free ! fr>
Date:       2011-02-18 15:11:48
Message-ID: 201102181611.49375.annemarie.mahfouf () free ! fr
[Download RAW message or body]

Hi Peter,

I think you have to close the review on reviewboard by yourself as my commit 
did not close it (it should have when I used
REVIEW:6512
in the commit log but maybe it did not work because I was not the one who 
issued the review).
The bug report got closed with the commit.

Thanks again for your contribution, best regards,

Anne-Marie

On Friday 18 February 2011 10:00:23 Anne-Marie Mahfouf wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6512/#review9882
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Hi Peter, I tested the layout and it's good!
> I'll commit it to kdeedu/ktouch/keyboards/ Thanks a lot for your first
> contribution to KTouch!
> 
> - Anne-Marie
> 
> On Feb. 17, 2011, 9:53 p.m., Peter Rüthemann wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/6512/
> > -----------------------------------------------------------
> > 
> > (Updated Feb. 17, 2011, 9:53 p.m.)
> > 
> > 
> > Review request for KDE-Edu.
> > 
> > 
> > Summary
> > -------
> > 
> > I created a bulgarian keyboard layout for KTouch. This solves the Bug
> > 148825.
> > 
> > This is my first patch, so let me know if i missed something.
> > 
> > Thank you
> > 
> > 
> > This addresses bug 148825.
> > 
> >     https://bugs.kde.org/show_bug.cgi?id=148825
> > 
> > Diffs
> > -----
> > 
> >   /trunk/KDE/kdeedu/bg.keyboard.xml PRE-CREATION
> > 
> > Diff: http://svn.reviewboard.kde.org/r/6512/diff
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Peter
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread]