From kde-edu-devel Tue Feb 15 23:53:18 2011 From: "Massimo Lo Iacono" Date: Tue, 15 Feb 2011 23:53:18 +0000 To: kde-edu-devel Subject: [kde-edu]: Review Request: Parley: [PATCH] Added dictation practice. Message-Id: <20110215235318.32209.18442 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=129781549031928 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2036844886==" --===============2036844886== Content-Type: multipart/alternative; boundary="===============5246687043249027093==" --===============5246687043249027093== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6489/ ----------------------------------------------------------- Review request for KDE-Edu. Summary ------- Hallo. I have made the modifications to add functionality for dictation practice. Dictation is a monolanguage type of practice. It consists a sound (only) qu= estion and a text solution in the same language of question. The language of practice is the first of the pair languageFrom/languageTo. For developers: Since the dictation practice is of the type monolanguage and the pre existe= nt code was for bilanguage practice, I modified a bit the code in order tha= t now it is adapt also for a monolanguage type of practice. I added these new 4 files in "src/4/kdeedu/parley/src/practice/" directory: dictationbackendmode.h dictationbackendmode.cpp dictationmodewidget.h dictationmodewidget.cpp I can send these file as attachments in the parley develop mailing list. IMPORTANT: to manage the visualisation of question and solution images, I w= as forced to create the new function: GuiFrontend::compareImage() and to modify the functions: AbstractBackendMode::setTestEntry MultipleChoiceBackendMode::setTestEntry ConjugationBackendMode::setTestEntry ComparisonBackendMode::setTestEntry = adding the rows: m_frontend->setQuestionImage m_frontend->setSolutionImage m_frontend->compareImage(); I created the patch from the 1218525 revision, almost 2 weeks old. I can successful compile and execute the code with my modifications. Diffs ----- /trunk/KDE/kdeedu/CMakeLists.txt 1218525 = /trunk/KDE/kdeedu/parley/src/CMakeLists.txt 1218525 = /trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h 1218525 = /trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/guifrontend.h 1218525 = /trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp 12185= 25 = /trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp 121852= 5 = /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h 1218525 = /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/settings/parley.kcfg 1218525 = /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp 1218525 = /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.ui 1218525 = Diff: http://svn.reviewboard.kde.org/r/6489/diff Testing ------- I can successful compile and execute the code with my modifications. Thanks, Massimo --===============5246687043249027093== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6489/

Review request for KDE-Edu.
By Massimo Lo Iacono.

Descripti= on

Hallo.
I have made the modifications to add functionality for dictation practice.

Dictation is a monolanguage type of practice. It consists a sound (only) qu=
estion and a text solution in the same language of question.

The language of practice is the first of the pair languageFrom/languageTo.

For developers:

Since the dictation practice is of the type monolanguage and the pre existe=
nt code was for bilanguage practice, I modified a bit the code in order tha=
t now it is adapt also for a monolanguage type of practice.

I added these new 4 files in "src/4/kdeedu/parley/src/practice/" =
directory:

  dictationbackendmode.h
  dictationbackendmode.cpp
  dictationmodewidget.h
  dictationmodewidget.cpp

I can send these file as attachments in the parley develop mailing list.

IMPORTANT: to manage the visualisation of question and solution images, I w=
as forced to create the new function:

  GuiFrontend::compareImage()

and to modify the functions:

  AbstractBackendMode::setTestEntry
  MultipleChoiceBackendMode::setTestEntry
  ConjugationBackendMode::setTestEntry
  ComparisonBackendMode::setTestEntry
  =

adding the rows:

  m_frontend->setQuestionImage
  m_frontend->setSolutionImage
  m_frontend->compareImage();

I created the patch from the 1218525 revision, almost 2 weeks old.

I can successful compile and execute the code with my modifications.

Testing <= /h1>
I can successful compile and execute the code with my modifi=
cations.

Diffs=

  • /trunk/KDE/kdeedu/CMakeLists.txt (1218525)=
  • /trunk/KDE/kdeedu/parley/src/CMakeLists.txt (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/guifrontend.h (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h (1218525)
  • /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/settings/parley.kcfg (1218525)
  • /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp (1218525)
  • /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.ui (1218525)

View Diff

--===============5246687043249027093==-- --===============2036844886== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============2036844886==--