[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Re: Review Request: Fix for bug 220828: anchor firstly
From: "Alexander Potashev" <aspotashev () gmail ! com>
Date: 2011-02-03 12:40:58
Message-ID: 20110203124058.19220.65461 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 2, 2011, 10:40 p.m., Alexander Potashev wrote:
> > The fix for anchors, pins and sticks now works. Though the bug still exists for disks, boxes, linear \
> > and circular motors.
> > @kde-edu people: When the patch will be OK (or may be it's already OK?), should I commit it, or may \
> > be Step is maintained by someone who is responsible for committing patches?
> > P.S.: I experienced random freezes, but hope that they are not related to the bug of interest.
>
> Sebastian Voecking wrote:
> The other ones can be fixed in the same way. I only missed these earlier. Only softbody does funny \
> things (position=(nan,nan)). But that's not related to the patch at all (it also does this without it). \
> I'll check tomorrow if it's somehow related to this bug.
> I can now commit it myself, since I got my own SVN access tonight. And I am going to maintain Step \
> myself in the future and just began exploring the code and to get a general idea of it.
> Anne-Marie Mahfouf wrote:
> @Alexander: Sebastian is taking over maintainship of Step (he is a student in physics and has an \
> excellent C++ knowledge and is experienced in physics simulation software!) Thanks a lot for testing \
> the patches! At some point in a few weeks or months we could maybe appeal for testers and do a full \
> day on IRC listing all the problems and cross-checking the bugs, I volunteer to organize it.
@Sebastian: welcome to the repository :)
Nice to see some activity in development of Step, because it was abandoned during the last 3 years.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6437/#review9796
-----------------------------------------------------------
On Feb. 2, 2011, 6:38 p.m., Sebastian Voecking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6437/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2011, 6:38 p.m.)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> The problem occurs for all type of items. The reason was that it was added to the worldmodel before the \
> correct position was set.
>
> This addresses bug 220828.
> https://bugs.kde.org/show_bug.cgi?id=220828
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/step/step/worldmodel.h 1218044
> /trunk/KDE/kdeedu/step/step/worldmodel.cc 1218044
> /trunk/KDE/kdeedu/step/step/worldgraphics.cc 1218044
>
> Diff: http://svn.reviewboard.kde.org/r/6437/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastian
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6437/">http://svn.reviewboard.kde.org/r/6437/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 2nd, 2011, 10:40 p.m., <b>Alexander Potashev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">The fix for anchors, pins and sticks now works. Though the bug still \
exists for disks, boxes, linear and circular motors.
@kde-edu people: When the patch will be OK (or may be it's already OK?), should I commit it, or may \
be Step is maintained by someone who is responsible for committing patches?
P.S.: I experienced random freezes, but hope that they are not related to the bug of interest.</pre>
</blockquote>
<p>On February 3rd, 2011, 12:12 a.m., <b>Sebastian Voecking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">The other ones can be fixed in the same way. I only missed these \
earlier. Only softbody does funny things (position=(nan,nan)). But that's not related to the patch at \
all (it also does this without it). I'll check tomorrow if it's somehow related to this bug.
I can now commit it myself, since I got my own SVN access tonight. And I am going to maintain Step myself \
in the future and just began exploring the code and to get a general idea of it.</pre> </blockquote>
<p>On February 3rd, 2011, 6:44 a.m., <b>Anne-Marie Mahfouf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">@Alexander: Sebastian is taking over maintainship of Step (he is a \
student in physics and has an excellent C++ knowledge and is experienced in physics simulation software!) \
Thanks a lot for testing the patches! At some point in a few weeks or months we could maybe appeal for \
testers and do a full day on IRC listing all the problems and cross-checking the bugs, I volunteer to \
organize it.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">@Sebastian: welcome to the repository :)
Nice to see some activity in development of Step, because it was abandoned during the last 3 years.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On February 2nd, 2011, 6:38 p.m., Sebastian Voecking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left \
top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Sebastian Voecking.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2011, 6:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem occurs for all type of items. \
The reason was that it was added to the worldmodel before the correct position was set.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=220828">220828</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/step/step/worldmodel.h <span style="color: grey">(1218044)</span></li>
<li>/trunk/KDE/kdeedu/step/step/worldmodel.cc <span style="color: grey">(1218044)</span></li>
<li>/trunk/KDE/kdeedu/step/step/worldgraphics.cc <span style="color: grey">(1218044)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6437/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic