[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Re: Review Request: Cantor: no deprecated functions
From: "Marco Martin" <notmart () gmail ! com>
Date: 2011-02-01 21:33:42
Message-ID: 20110201213342.9084.68454 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 26, 2011, 5:17 p.m., Alexander Rieder wrote:
> > With this patch applied, all the Actions, that are provided by the Cant=
orPart (like save, zoomIn/out, evaluate etc.) stop appearing in both, the m=
enu and the toolbar.
> > Can you please look into this?
> =
> Alexander Rieder wrote:
> the problem seems to be, that the cantor_part.rc file is not found (i=
t says "KXMLGUIClient::setXMLFile: cannot find .rc file "cantor_part.rc" fo=
r component "cantor" " in the debug output). The problem seems to go away i=
f i change the install directory of cantor_part.rc in the CMakeLists.txt fr=
om ${DATA_INSTALL_DIR}/cantorpart to ${DATA_INSTALL_DIR}/cantor but i don't=
know if this is a proper fix.
> =
> Marco Martin wrote:
> couldn't anser before, sorry ;)
> that may be it, since i see that konsole that was also recently porte=
d installs its rc in ${DATA_INSTALL_DIR}/konsole
> =
> Alexander Rieder wrote:
> given that i don't really know why it was installed in its own direct=
ory in the first place, and it doesn't seem to break anything, can you chan=
ge the install dir, and commit this patch? Or should I do it?
ok, i can do it, sure :)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6412/#review9732
-----------------------------------------------------------
On Jan. 25, 2011, 4:24 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6412/
> -----------------------------------------------------------
> =
> (Updated Jan. 25, 2011, 4:24 p.m.)
> =
> =
> Review request for KDE-Edu.
> =
> =
> Summary
> -------
> =
> this changes the calls to deprected functions in ktabwidget and kpart
> necessary to build under the mobile profile
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeedu/cantor/src/cantor.cpp 1216468 =
> /trunk/KDE/kdeedu/cantor/src/cantor_part.h 1216468 =
> /trunk/KDE/kdeedu/cantor/src/cantor_part.cpp 1216468 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6412/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6412/">http://svn.reviewboard.kde.org/r/6412/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 26th, 2011, 5:17 p.m., <b>Alexander \
Rieder</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch applied, all the Actions, that are provided by the \
CantorPart (like save, zoomIn/out, evaluate etc.) stop appearing in both, the menu \
and the toolbar. Can you please look into this?</pre>
</blockquote>
<p>On January 26th, 2011, 6:13 p.m., <b>Alexander Rieder</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the problem seems to be, \
that the cantor_part.rc file is not found (it says "KXMLGUIClient::setXMLFile: \
cannot find .rc file "cantor_part.rc" for component "cantor" \
" in the debug output). The problem seems to go away if i change the install \
directory of cantor_part.rc in the CMakeLists.txt from ${DATA_INSTALL_DIR}/cantorpart \
to ${DATA_INSTALL_DIR}/cantor but i don't know if this is a proper fix.</pre> \
</blockquote>
<p>On January 30th, 2011, 3:27 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">couldn't anser \
before, sorry ;) that may be it, since i see that konsole that was also recently \
ported installs its rc in ${DATA_INSTALL_DIR}/konsole</pre> </blockquote>
<p>On February 1st, 2011, 9:31 p.m., <b>Alexander Rieder</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given that i don't \
really know why it was installed in its own directory in the first place, and it \
doesn't seem to break anything, can you change the install dir, and commit this \
patch? Or should I do it?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, i can do it, sure \
:)</pre> <br />
<p>- Marco</p>
<br />
<p>On January 25th, 2011, 4:24 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2011, 4:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this changes the calls to deprected functions in ktabwidget and kpart \
necessary to build under the mobile profile</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/src/cantor.cpp <span style="color: \
grey">(1216468)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor_part.h <span style="color: \
grey">(1216468)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor_part.cpp <span style="color: \
grey">(1216468)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6412/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic