[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Re: Review Request: Marble: no deprecated
From: "Anne-Marie Mahfouf" <annma () kde ! org>
Date: 2011-01-26 16:04:47
Message-ID: 20110126160447.19704.84573 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6413/#review9729
-----------------------------------------------------------
Ship it!
Torsten said it's fine for trunk.
- Anne-Marie
On Jan. 25, 2011, 4:29 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6413/
> -----------------------------------------------------------
> =
> (Updated Jan. 25, 2011, 4:29 p.m.)
> =
> =
> Review request for KDE-Edu.
> =
> =
> Summary
> -------
> =
> this ports the usage of kpart away from deprecated functions
> needed to build under the mobile profile
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeedu/marble/src/KdeMainWindow.cpp 1216468 =
> /trunk/KDE/kdeedu/marble/src/marble_part.h 1216468 =
> /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1216468 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6413/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6413/">http://svn.reviewboard.kde.org/r/6413/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Torsten said it's fine for trunk.</pre> <br />
<p>- Anne-Marie</p>
<br />
<p>On January 25th, 2011, 4:29 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left \
top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2011, 4:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this ports the usage of kpart away from \
deprecated functions needed to build under the mobile profile</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/KdeMainWindow.cpp <span style="color: grey">(1216468)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble_part.h <span style="color: grey">(1216468)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1216468)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6413/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic