'[kde-edu]: Re: Review Request: Cantor: Use default backend if'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: Re: Review Request: Cantor: Use default backend if
From:       "Alexander Rieder" <alexanderrieder () gmail ! com>
Date:       2010-12-18 20:43:17
Message-ID: 20101218204317.24990.81675 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6121/#review9305
-----------------------------------------------------------

the code looks good. unfortunately this will have to wait until trunk is open again \
for 4.7

- Alexander

On 2010-12-15 18:12:50, Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6121/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 18:12:50)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> 1) Use the default backend when creating a new worksheet. It only asks for the \
> default backend if no default backend is given (changed that to the default in the \
> config file, to ask for the backend when Cantor is started the first time). 2) \
> Change addWorksheet() to display the newly created tab. 3) Add a menu to the file \
> menu with a list of the available and enabled backends to create a new worksheet \
> with a specific backend. 
> 
> This addresses bug 225726.
> https://bugs.kde.org/show_bug.cgi?id=225726
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeedu/cantor/src/cantor.cpp 1206532 
> trunk/KDE/kdeedu/cantor/src/cantor.kcfg 1206532 
> trunk/KDE/kdeedu/cantor/src/cantor_shell.rc 1206532 
> 
> Diff: http://svn.reviewboard.kde.org/r/6121/diff
> 
> 
> Testing
> -------
> 
> Tested and it was fine.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6121/">http://svn.reviewboard.kde.org/r/6121/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the code looks good. \
unfortunately this will have to wait until trunk is open again for 4.7</pre>  <br />

<p>- Alexander</p>

<br />
<p>On December 15th, 2010, 6:12 p.m., Jan Gerrit Marker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE-Edu.</div>
<div>By Jan Gerrit Marker.</div>

<p style="color: grey;"><i>Updated 2010-12-15 18:12:50</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Use the default backend when creating a new worksheet. It only asks \
for the default backend if no default backend is given (changed that to the default \
in the config file, to ask for the backend when Cantor is started the first time). 2) \
Change addWorksheet() to display the newly created tab. 3) Add a menu to the file \
menu with a list of the available and enabled backends to create a new worksheet with \
a specific backend.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and it was fine.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=225726">225726</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdeedu/cantor/src/cantor.cpp <span style="color: \
grey">(1206532)</span></li>

 <li>trunk/KDE/kdeedu/cantor/src/cantor.kcfg <span style="color: \
grey">(1206532)</span></li>

 <li>trunk/KDE/kdeedu/cantor/src/cantor_shell.rc <span style="color: \
grey">(1206532)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6121/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 