[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]:  Review Request: Remove kde3 support from KStars
From:       "Aleix Pol" <aleixpol () kde ! org>
Date:       2010-11-30 1:05:50
Message-ID: 20101130010550.18100.53132 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6016/
-----------------------------------------------------------

Review request for KDE-Edu.


Summary
-------

Makes it possible to compile KDE Edu without KDE3/Qt3-support libraries. Ch=
anges a bunch of Q3ListBox -> QListWidget.

Didn't test it, take it just as a suggestion. I think it's very important t=
o drop such dependency.


Diffs
-----

  /trunk/KDE/kdeedu/kstars/kstars/CMakeLists.txt 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/dialogs/locationdialog.cpp 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/dialogs/locationdialog.ui 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/dialogs/wizlocation.ui 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/kswizard.cpp 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/tools/argloadcolorscheme.ui 1202173 =

  /trunk/KDE/kdeedu/kstars/kstars/tools/scriptbuilder.cpp 1202173 =


Diff: http://svn.reviewboard.kde.org/r/6016/diff


Testing
-------


Thanks,

Aleix


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6016/">http://svn.reviewboard.kde.org/r/6016/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE-Edu.</div>
<div>By Aleix Pol.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes it possible to compile KDE Edu without KDE3/Qt3-support libraries. \
Changes a bunch of Q3ListBox -&gt; QListWidget.

Didn&#39;t test it, take it just as a suggestion. I think it&#39;s very important to \
drop such dependency.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeedu/kstars/kstars/CMakeLists.txt <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/dialogs/locationdialog.cpp <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/dialogs/locationdialog.ui <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/dialogs/wizlocation.ui <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/kswizard.cpp <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/tools/argloadcolorscheme.ui <span style="color: \
grey">(1202173)</span></li>

 <li>/trunk/KDE/kdeedu/kstars/kstars/tools/scriptbuilder.cpp <span style="color: \
grey">(1202173)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6016/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic