'[kde-edu]: Re: Review Request: Removing code duplication in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: Re: Review Request: Removing code duplication in
From:       "Cezar Mocan" <mocancezar () gmail ! com>
Date:       2010-11-25 18:03:44
Message-ID: 20101125180344.20042.37269 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5969/
-----------------------------------------------------------

(Updated 2010-11-25 18:03:44.448352)

Review request for KDE-Edu and Victor Carbune.

Changes
-------

Solved the context menu for Session Plan.

Summary
-------

Modified ObservingList.cpp and ObservingList.h. Removed code duplication.

Diffs (updated)
-----

  trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.h 1200379 =

  trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp 1200379 =

Diff: http://svn.reviewboard.kde.org/r/5969/diff

Testing
-------

Thanks,

Cezar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5969/">http://svn.reviewboard.kde.org/r/5969/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE-Edu and Victor Carbune.</div>
<div>By Cezar Mocan.</div>

<p style="color: grey;"><i>Updated 2010-11-25 18:03:44.448352</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solved the context menu for Session Plan.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Modified ObservingList.cpp and ObservingList.h. Removed code \
duplication.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.h <span \
style="color: grey">(1200379)</span></li>

 <li>trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp <span \
style="color: grey">(1200379)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5969/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 