'[kde-edu]: Review Request: Replace "Play" button with a button with'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: Review Request: Replace "Play" button with a button with
From:       "Alexander Potashev" <aspotashev () gmail ! com>
Date:       2010-10-24 9:11:51
Message-ID: 20101024091151.4179.18836 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5686/
-----------------------------------------------------------

Review request for KDE-Edu.

Summary
-------

Using of a PushButton with text (Play/Pause) was bad, because:
1. The button had different sizes when the text on it was "Play" or "Pause",
2. Localization teams needed to guess short translations, otherwise the sli=
der becomes shorter (and, even in English version a button with an icon sav=
es some space over a button with text).

Diffs
-----

Diff: http://svn.reviewboard.kde.org/r/5686/diff

Testing
-------

Thanks,

Alexander

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5686/">http://svn.reviewboard.kde.org/r/5686/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE-Edu.</div>
<div>By Alexander Potashev.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using of a PushButton \
with text (Play/Pause) was bad, because: 1. The button had different sizes when the text on it \
was &quot;Play&quot; or &quot;Pause&quot;, 2. Localization teams needed to guess short \
translations, otherwise the slider becomes shorter (and, even in English version a button with \
an icon saves some space over a button with text).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5686/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 