[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: [kde-edu]: Review Request: Default Variable Model for Cantor's
From: "Alexander Rieder" <alexanderrieder () gmail ! com>
Date: 2010-09-21 18:09:02
Message-ID: 20100921180902.26141.55341 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5386/#review7710
-----------------------------------------------------------
Ship it!
i haven't tested it, but it looks good. I'm looking forward to see it used =
in the octave backend
- Alexander
On 2010-09-21 07:16:46, Miha Cancula wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5386/
> -----------------------------------------------------------
> =
> (Updated 2010-09-21 07:16:46)
> =
> =
> Review request for KDE-Edu and Alexander Rieder.
> =
> =
> Summary
> -------
> =
> This patch introduces a new class DefaultVariableModel, which can be used=
for convenience by the backends to show and modify their variables. It sub=
classes QAbstractTableModel, and provides a convenience API with functions =
like addVariable() and removeVariable(). =
> =
> Most of the QAbstractItemModel interface code was copied from KAlgebra's =
implementation. =
> =
> The patch also includes extra methods to the VariableManagementExtension =
not only for defining, but also for modifying and removing variables. The m=
odel uses these methods in the setData() function to modify or delete varia=
bles. This way the backend must only implement the Extension's functions an=
d variable modifying works automatically. =
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1177594 =
> /trunk/KDE/kdeedu/cantor/src/lib/defaultvariablemodel.h PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/lib/defaultvariablemodel.cpp PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/lib/extension.h 1177594 =
> /trunk/KDE/kdeedu/cantor/src/lib/extension.cpp 1177594 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5386/diff
> =
> =
> Testing
> -------
> =
> I made the Octave backend use it, without subclassing, and all the wanted=
functions work. =
> =
> =
> Thanks,
> =
> Miha
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5386/">http://svn.reviewboard.kde.org/r/5386/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i haven't tested it, \
but it looks good. I'm looking forward to see it used in the octave backend</pre> \
<br />
<p>- Alexander</p>
<br />
<p>On September 21st, 2010, 7:16 a.m., Miha Cancula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu and Alexander Rieder.</div>
<div>By Miha Cancula.</div>
<p style="color: grey;"><i>Updated 2010-09-21 07:16:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch introduces a new class DefaultVariableModel, which can be \
used for convenience by the backends to show and modify their variables. It \
subclasses QAbstractTableModel, and provides a convenience API with functions like \
addVariable() and removeVariable().
Most of the QAbstractItemModel interface code was copied from KAlgebra's \
implementation.
The patch also includes extra methods to the VariableManagementExtension not only for \
defining, but also for modifying and removing variables. The model uses these methods \
in the setData() function to modify or delete variables. This way the backend must \
only implement the Extension's functions and variable modifying works \
automatically. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I made the Octave backend use it, without subclassing, and all the \
wanted functions work. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt <span style="color: \
grey">(1177594)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/defaultvariablemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/defaultvariablemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/extension.h <span style="color: \
grey">(1177594)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/extension.cpp <span style="color: \
grey">(1177594)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5386/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic