[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: [kde-edu]: Review Request: Add variable management panel in
From: "Alexander Rieder" <alexanderrieder () gmail ! com>
Date: 2010-09-16 12:23:24
Message-ID: 20100916122324.13435.82288 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-16 07:51:08, Miha Cancula wrote:
> > That's a very nice thing, I'm sorry I didn't comment earlier, but I really didn't \
> > have much to say. It seems it took some work, but the result is really useful.
> > I like it, especially the fact that there's no SessionExtension needed, only a \
> > normal one and a standard Model.
> > I'm wondering if there should be a DefaultModel in the library that would \
> > implement most common virtual functions, and have an API for convenience. I'm \
> > willing to work on that, if you wish.
> > Also, I'll be implementing it in Octave. Anyway, great work.
Yes, a default model with some convenience API would be nice
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5354/#review7634
-----------------------------------------------------------
On 2010-09-15 22:54:50, Alexander Rieder wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5354/
> -----------------------------------------------------------
>
> (Updated 2010-09-15 22:54:50)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> Implement basics for a VariableManager panel in Cantor.
> This change is rather big, as it involves some completely new plugin interfaces to \
> make it as easy as possible to add similar things later. This patch only contains a \
> simple GUI and a dummy implementation in the NullBackend. (to test it start cantor \
> with --backend=nullbackend), and of course the new interfaces. First it introduces \
> Extensions for the Session (so far they were only for the Backend) to allow \
> optional hooks into the workings inside the session. Also it introduces so called \
> PanelPlugins, these are plugins that create widgets that are shown in the side \
> panel depending on the exported extensions by the session. The current HelpPanel is \
> turned into such a panel, and the new VariableManager is one too. On the backend \
> side, one only has to implement the VariableManagerExtension, and emit the signals \
> appropriately/implement the functions there. I would really like some feedback on \
> this API (for both VariableManagerExtension and PanelPlugin side), please have a \
> look, and possibly suggest better namings than PanelPlugin or SessionExtension
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/CMakeLists.txt 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrabackend.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebraextensions.h PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebraextensions.cpp PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrasession.h 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrasession.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/null/nullsession.h 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/null/nullsession.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/backends/null/nullvariablemgrextension.h PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/backends/null/nullvariablemgrextension.cpp \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/cantor.h 1174987
> /trunk/KDE/kdeedu/cantor/src/cantor.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/cantor_part.h 1174987
> /trunk/KDE/kdeedu/cantor/src/cantor_part.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/backend.h 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/backend.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/cantor_panelplugin.desktop PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/lib/extension.h 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/extension.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/panelplugin.h PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/lib/panelplugin.cpp PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/lib/panelpluginhandler.h PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/lib/panelpluginhandler.cpp PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/lib/session.h 1174987
> /trunk/KDE/kdeedu/cantor/src/lib/session.cpp 1174987
> /trunk/KDE/kdeedu/cantor/src/panelplugins/CMakeLists.txt PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/CMakeLists.txt PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.cpp \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.desktop \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.h PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/CMakeLists.txt PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/newvardlg.ui PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.h \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.cpp \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.desktop \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerwidget.h \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerwidget.cpp \
> PRE-CREATION
> /trunk/KDE/kdeedu/cantor/src/worksheet.cpp 1174987
>
> Diff: http://svn.reviewboard.kde.org/r/5354/diff
>
>
> Testing
> -------
>
> This is mostly a preview for the new APIs, but all the functionality should work as \
> it used to (I didn't notice any regressions). The variable management works for the \
> dummy implementation in the NullBackend
>
> Screenshots
> -----------
>
> The Variable Manager plugin
> http://svn.reviewboard.kde.org/r/5354/s/503/
>
>
> Thanks,
>
> Alexander
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5354/">http://svn.reviewboard.kde.org/r/5354/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 16th, 2010, 7:51 a.m., <b>Miha \
Cancula</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">That's a very nice thing, I'm sorry I didn't comment \
earlier, but I really didn't have much to say. It seems it took some work, but \
the result is really useful.
I like it, especially the fact that there's no SessionExtension needed, only a \
normal one and a standard Model.
I'm wondering if there should be a DefaultModel in the library that would \
implement most common virtual functions, and have an API for convenience. I'm \
willing to work on that, if you wish.
Also, I'll be implementing it in Octave. Anyway, great work. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, a default model \
with some convenience API would be nice</pre> <br />
<p>- Alexander</p>
<br />
<p>On September 15th, 2010, 10:54 p.m., Alexander Rieder wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Alexander Rieder.</div>
<p style="color: grey;"><i>Updated 2010-09-15 22:54:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement basics for a VariableManager panel in Cantor. This change is \
rather big, as it involves some completely new plugin interfaces to make it as easy \
as possible to add similar things later. This patch only contains a simple GUI and a \
dummy implementation in the NullBackend. (to test it start cantor with \
--backend=nullbackend), and of course the new interfaces. First it introduces \
Extensions for the Session (so far they were only for the Backend) to allow optional \
hooks into the workings inside the session. Also it introduces so called \
PanelPlugins, these are plugins that create widgets that are shown in the side panel \
depending on the exported extensions by the session. The current HelpPanel is turned \
into such a panel, and the new VariableManager is one too. On the backend side, one \
only has to implement the VariableManagerExtension, and emit the signals \
appropriately/implement the functions there. I would really like some feedback on \
this API (for both VariableManagerExtension and PanelPlugin side), please have a \
look, and possibly suggest better namings than PanelPlugin or SessionExtension</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is mostly a preview for the new APIs, but all the functionality \
should work as it used to (I didn't notice any regressions). The variable \
management works for the dummy implementation in the NullBackend</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/src/CMakeLists.txt <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/CMakeLists.txt <span \
style="color: grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrabackend.cpp <span \
style="color: grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebraextensions.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebraextensions.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrasession.h <span \
style="color: grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/kalgebra/kalgebrasession.cpp <span \
style="color: grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/null/nullsession.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/null/nullsession.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/null/nullvariablemgrextension.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/null/nullvariablemgrextension.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor_part.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/cantor_part.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/backend.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/backend.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/cantor_panelplugin.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/extension.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/extension.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/panelplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/panelplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/panelpluginhandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/panelpluginhandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/session.h <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/session.cpp <span style="color: \
grey">(1174987)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/helppanel/helppanelplugin.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/newvardlg.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerplugin.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerwidget.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/panelplugins/variablemgr/variablemanagerwidget.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/worksheet.cpp <span style="color: \
grey">(1174987)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5354/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5354/s/503/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/14/variable_mgr_400x100.png" \
style="border: 1px black solid;" alt="The Variable Manager plugin" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic