[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: [kde-edu]: Review Request: Titration calculator in Kalzium
From: "Luca Tringali" <tringalinvent () libero ! it>
Date: 2010-08-09 21:17:59
Message-ID: 20100809211759.10968.84609 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4667/
-----------------------------------------------------------
(Updated 2010-08-09 21:17:58.654953)
Review request for KDE-Edu.
Changes
-------
Ok Etienne, I did the changes you suggested, I'll explain every changes in =
another mail.
Summary
-------
These changes are needed to implement the titration calculator for kalzium.=
Anyway it's necessary to add the files titrationCalculator.cpp, titrationC=
alculator.h, titrationCalculator.ui (you can find it here http://zorbaproje=
ct.uuuq.com/upload/titrationCalculator.tar.gz) into the directory src/calcu=
lator/. I cannot do this because post-review allows only to edit existing f=
iles and not to add new files, and I do not have any svn account. =
Tell me if I did something wrong.
Diffs (updated)
-----
/trunk/KDE/kdeedu/kalzium/src/CMakeLists.txt 1145939 =
/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.h 1145939 =
/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.cpp 1145939 =
/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.ui 1145939 =
/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.h PRE-CREATI=
ON =
/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.cpp PRE-CREA=
TION =
/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.ui PRE-CREAT=
ION =
Diff: http://reviewboard.kde.org/r/4667/diff
Testing
-------
Screenshots
-----------
Titration example
http://reviewboard.kde.org/r/4667/s/460/
Thanks,
Luca
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4667/">http://reviewboard.kde.org/r/4667/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Luca Tringali.</div>
<p style="color: grey;"><i>Updated 2010-08-09 21:17:58.654953</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ok Etienne, I did the changes you suggested, I'll explain every \
changes in another mail.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These changes are needed to implement the titration calculator for \
kalzium. Anyway it's necessary to add the files titrationCalculator.cpp, \
titrationCalculator.h, titrationCalculator.ui (you can find it here \
http://zorbaproject.uuuq.com/upload/titrationCalculator.tar.gz) into the directory \
src/calculator/. I cannot do this because post-review allows only to edit existing \
files and not to add new files, and I do not have any svn account. Tell me if I did \
something wrong. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/kalzium/src/CMakeLists.txt <span style="color: \
grey">(1145939)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.h <span style="color: \
grey">(1145939)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.cpp <span style="color: \
grey">(1145939)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/calculator.ui <span style="color: \
grey">(1145939)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4667/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4667/s/460/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/07/16/titrationcalculator__400x100.png" \
style="border: 1px black solid;" alt="Titration example" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic