[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: [kde-edu]: Review Request: Tests for Cantor backends
From: "Alexander Rieder" <alexanderrieder () gmail ! com>
Date: 2010-07-16 16:17:11
Message-ID: 20100716161711.11765.58798 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4616/#review6619
-----------------------------------------------------------
Ship it!
Looks good, please commit. the maxima and sage tests were already broken.
- Alexander
On 2010-07-16 15:54:14, Miha Cancula wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4616/
> -----------------------------------------------------------
> =
> (Updated 2010-07-16 15:54:14)
> =
> =
> Review request for KDE-Edu and Alexander Rieder.
> =
> =
> Summary
> -------
> =
> This patch introduces a BackendTest class which has the functionality pre=
viously shared by tests for Maxima and Sage backends. I also included a tes=
t for the new Octave backend, which also uses the same class. =
> =
> The only new functionality is skipping tests for backends which are not u=
sable (either not installed or missing runtime requirements). Otherwise it'=
s mostly copy/paste, so I kept Alexander's copyright in the new class. =
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeedu/cantor/CMakeLists.txt 1149794 =
> /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1149794 =
> /trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt 1149810 =
> /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp PRE-CREATIO=
N =
> /trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt 1149810 =
> /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp PRE-CREATIO=
N =
> /trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt 1149810 =
> /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1149794 =
> /trunk/KDE/kdeedu/cantor/src/lib/test/CMakeLists.txt PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.h PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.cpp PRE-CREATION =
> /trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt 1149809 =
> /trunk/KDE/kdeedu/cantor/tests/testmaxima.h 1149809 =
> /trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp 1149809 =
> /trunk/KDE/kdeedu/cantor/tests/testsage.h 1149809 =
> /trunk/KDE/kdeedu/cantor/tests/testsage.cpp 1149809 =
> =
> Diff: http://reviewboard.kde.org/r/4616/diff
> =
> =
> Testing
> -------
> =
> All three tests compile and run. Maxima's testPlot fails, but I think tha=
t happened before the change too. I don't have Sage installed, so its test =
is successfully skipped. =
> =
> =
> Thanks,
> =
> Miha
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4616/">http://reviewboard.kde.org/r/4616/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Looks good, please commit. the maxima and sage tests were already broken.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 16th, 2010, 3:54 p.m., Miha Cancula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu and Alexander Rieder.</div>
<div>By Miha Cancula.</div>
<p style="color: grey;"><i>Updated 2010-07-16 15:54:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch introduces a BackendTest class \
which has the functionality previously shared by tests for Maxima and Sage backends. \
I also included a test for the new Octave backend, which also uses the same class.
The only new functionality is skipping tests for backends which are not usable \
(either not installed or missing runtime requirements). Otherwise it's mostly \
copy/paste, so I kept Alexander's copyright in the new class. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">All three tests compile and run. Maxima's \
testPlot fails, but I think that happened before the change too. I don't have \
Sage installed, so its test is successfully skipped. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/CMakeLists.txt <span style="color: \
grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/CMakeLists.txt <span style="color: \
grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt <span style="color: \
grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt <span style="color: \
grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt <span style="color: \
grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt <span style="color: \
grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/test/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt <span style="color: \
grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.h <span style="color: \
grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp <span style="color: \
grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.h <span style="color: \
grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.cpp <span style="color: \
grey">(1149809)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4616/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic