[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: Review Request: krazy fixes: kdeedu kig: QLatin1String,
From:       "Pieter Vande Wyngaerde" <pietervandewyngaerde+kdereview () gmail ! com>
Date:       2010-03-21 22:31:51
Message-ID: 20100321223151.25192.2488 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3344/
-----------------------------------------------------------

Review request for KDE-Edu.


Summary
-------

Fixes for:
Check for strings used improperly or should be i18n. [strings]...OOPS! 13 issues found!

    * kfile/kfile_kig.cpp: QLatin1String issues line# 62,71 (2)
    * filters/native-filter.cc: QLatin1String issues line# 119,130,742,752 (4)
    * filters/cabri-utils.cc: QLatin1String issues line# 604,710,722,727,764 (5)
    * filters/cabri-filter.cc: QLatin1String issues line# 153 (1)
    * filters/kseg-filter.cc: QLatin1String issues line# 216 (1)

Check for postfix usage of ++ and -- [postfixop]...OOPS! 3 issues found!    ( not all issues fixed )

    * objects/object_factory.cc: line# 112 (1) 

Check single-char QString operations for efficiency [doublequote_chars]...OOPS! 1 issues found!

    * kig/main.cpp: line# 116 (1)

Check for spelling errors [spelling]...OOPS! 1 issues found!

    * kig/kig_view.h: line# 130[[optimise]] (1)


Diffs
-----

  trunk/KDE/kdeedu/kig/filters/cabri-utils.cc 1106123 
  trunk/KDE/kdeedu/kig/filters/native-filter.cc 1106123 
  trunk/KDE/kdeedu/kig/kfile/kfile_kig.cpp 1106123 
  trunk/KDE/kdeedu/kig/kig/kig_view.h 1106123 
  trunk/KDE/kdeedu/kig/kig/main.cpp 1106123 
  trunk/KDE/kdeedu/kig/objects/object_factory.cc 1106123 

Diff: http://reviewboard.kde.org/r/3344/diff


Testing
-------

none.
please check (and commit) 


Thanks,

Pieter

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]