[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Review Request: Display as many choices as set in the
From: Nicolas_RĂ©au <thelwyn () gmail ! com>
Date: 2010-02-07 15:56:52
Message-ID: 20100207155652.29127.75170 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2852/
-----------------------------------------------------------
Review request for KDE-Edu and Frederik Gladhorn.
Summary
-------
The radio buttons in multiple choice mode are now displayed according to the option \
set by the user in the config dialog (instead of being hardcoded to 5 choices).
Diffs
-----
branches/work/parley-practice/parley/src/practice/abstractwidget.h 1085335
branches/work/parley-practice/parley/src/practice/flashcardmodewidget.h 1085335
branches/work/parley-practice/parley/src/practice/flashcardmodewidget.cpp 1085335
branches/work/parley-practice/parley/src/practice/guifrontend.h 1085335
branches/work/parley-practice/parley/src/practice/guifrontend.cpp 1085335
branches/work/parley-practice/parley/src/practice/multiplechoicebackendmode.cpp \
1085335 branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.h \
1085335 branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.cpp \
1085335 branches/work/parley-practice/parley/src/practice/abstractfrontend.h \
1085335 branches/work/parley-practice/parley/src/practice/practice_widget_multiplechoice.ui \
1085335 branches/work/parley-practice/parley/src/practice/writtenpracticewidget.h \
1085335 branches/work/parley-practice/parley/src/practice/writtenpracticewidget.cpp \
1085335
Diff: http://reviewboard.kde.org/r/2852/diff
Testing
-------
It works fine here. However I'm not satisfied of my code: I feel like I'm touching \
some files i shouldn't have too.
Please review it and tell if it's bad implemented or how it can be improved. (btw \
I've not removed my debug messages from the diff yet).
Thanks,
Nicolas
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic