[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    [kde-edu]: KDE/kdeedu/libkdeedu/extdate
From:       Jason Harris <kstars () 30doradus ! org>
Date:       2006-09-15 21:46:03
Message-ID: 1158356763.827191.302.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 584944 by harris:

Fixed crash condition in ExtDate::fromString(QString, QDateFormat).
When using the TextFormat QDateFormat, the code creates a QStringList 
from the space-separated fields of the input string, but it then assumed 
that the stringlist contains at least three members, which caused a 
crash when this was not the case.  Now, it will return an invalid 
ExtDate if the stringlist contains fewer than three members.

Thanks for the tip, Jasem.

CCMAIL: kde-edu@kde.org
CCMAIL: kstars-devel@kde.org



 M  +4 -0      extdatetime.cpp  


--- trunk/KDE/kdeedu/libkdeedu/extdate/extdatetime.cpp #584943:584944
@@ -494,6 +494,10 @@
 			//Three possible date formats:
 			//dd mth yyyy; mth dd yyyy; wkd mth dd yyyy
 			QStringList ss = s.split( " " );
+
+			//Return invalid if we don't have at least 3 fields
+			if ( ss.size() < 3 ) return dt;
+
 			bool ok = false;
 			int month = -1;
 			uint imonth = 0;
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]