[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: [kde-edu-devel] math app - design version 0.1
From:       arnold.kraschinski () t-online ! de (arnold)
Date:       2002-08-20 5:04:32
[Download RAW message or body]

Hello,

thank you for the patches.

Arnold


>
> Hi, i've only just found the time to look at your code, and i must say
> i'm impressed...  Seems to be rather usable already..
> Here are some comments ( and a small patch i made to get it to
> compile, and to fix a crash when you forget to put the plugin in a
> KTrader search path...)
> first the patch ( i edited it, to get rid of differences in
> Makefile.in's and such, so i don't know if patch(1) wil still accept
> it.. )
>
> diff -ur kmath-0.1/keduparts/Makefile.am kmath-0.1.nw/keduparts/Makefile.am
> --- kmath-0.1/keduparts/Makefile.am	Sun Aug 18 21:09:04 2002
> +++ kmath-0.1.nw/keduparts/Makefile.am	Mon Aug 19 22:51:00 2002
> @@ -1,7 +1,7 @@
>  ####### General stuff
>
>  INCLUDES= -I$(srcdir)/../   $(all_includes)
> -libkeduparts_la_LDFLAGS = $(KDE_MT_LDFLAGS) -version-info 3:0:1
> -no-undefined +# you need $(all_libraries here or else it will not link on
> systems +# where kdelibs are not installed in /usr/lib (like mine ;)
> +libkeduparts_la_LDFLAGS = $(KDE_MT_LDFLAGS) -version-info 3:0:1
> -no-undefined $(all_libraries) libkeduparts_la_LIBADD  = $(LIB_KIO)
> $(LIB_KPARTS)
>
>  check-local:
>
> diff -ur kmath-0.1/kmath/kmath/kmath.cpp kmath-0.1.nw/kmath/kmath/kmath.cpp
> --- kmath-0.1/kmath/kmath/kmath.cpp	Sun Aug 18 21:09:04 2002
> +++ kmath-0.1.nw/kmath/kmath/kmath.cpp	Mon Aug 19 23:01:57 2002
> @@ -152,6 +152,7 @@
>          // itself can't do anything useful
>          KMessageBox::error(this, "Could not find our Part!");
>          kapp->quit();
> +       // kapp->quit() means "quit on the next time we come in the
> +       // event loop.." without this return you end up executing the
> +       // rest of this function any way, which leads to a crash...
> +	return;
>      }
>

_______________________________________________
kde-edu-devel mailing list
kde-edu-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-edu-devel
[prev in list] [next in list] [prev in thread] [next in thread]