From kde-edu-devel Mon Jul 15 13:41:52 2002 From: Scott Wheeler Date: Mon, 15 Jul 2002 13:41:52 +0000 To: kde-edu-devel Subject: Re: [kde-edu-devel] mini-rant (was: KPopupMenu on QPushButton in kmessedword) X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=102674070602185 Just a note -- not specifically directed at Sebastian since I've had to fix= =20 this a few times other places recently: * Please, do not commit code that you know will not compile! * It's not as big a deal since this was in kdenonbeta, but it's a bad idea th= ere=20 too. Especially in the kdeedu module do not commit code that you know is=20 broken. =20 The other part of this is: * Please, make sure that your code compiles before you commit it. * There are of course times when it's impossible to tell that you're doing=20 something that won't compile on a different compiler/platform, but try to b= e=20 careful. I've seen things a couple of times that I know wouldn't have=20 compiled on any platform or compiler in CVS. =20 That will be all for now. ;-) =2DScott p.s. Oh, and keep up the good work. This is only a mini-rant after all. := =2D) On Monday 15 July 2002 8:40, Sebastian Stein wrote: > I have commited the version with the bug to cvs so that you can checkout = it > and maybe help me. The problem is in gui_qt.h and gui_qt.cpp > (kdenonbeta/kbruch). _______________________________________________ kde-edu-devel mailing list kde-edu-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/kde-edu-devel