[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    D27583: rebuild mosaic multiple dataset
From:       Deepak  Kumar <noreply () phabricator ! kde ! org>
Date:       2020-03-08 19:08:14
Message-ID: e1ff1f08e59fb1a45c6d8b5647d31355 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dekumar added inline comments.

INLINE COMMENTS

> jjazeix wrote in Data.qml:29
> The number of items is duplicated.
> Maybe naming the value in the table is better:
> rowCount: 2
> columnCount: 1

I have just updated the diff by adding layout rows and columns in form of 2d array. \
Let me know if this is all good or I shall make use of 4 different objects. Thanks!

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27583

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">dekumar added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D27583">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27583#inline-157002">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">Data.qml:29</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">The number of items is duplicated.<br /> Maybe naming the value in the table is \
                better:<br />
rowCount: 2<br />
columnCount: 1</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
have just updated the diff by adding layout rows and columns in form of 2d array. Let \
me know if this is all good or I shall make use of 4 different objects.<br /> \
Thanks!</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27583">https://phabricator.kde.org/D27583</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix, timotheegiet, \
echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]