[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    D15137: Proper silencing for the switch-case fall-through warning
From:       Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date:       2018-08-29 7:10:56
Message-ID: 0983d043a4ed20350b8db6f2372aee06 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
TallFurryMan added a project: KDE Edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This changeset silences the gcc warning for the case fall-through.
  No idea if this will work without warning for msvc, but that doesn't change much \
compared to the previous state.  C++17 can use \
"<https://phabricator.kde.org/w/fallthrough/>;" to specify an execution path that \
intentionally falls through the following case.  Q_FALLTHROUGH was introduced in \
QT5.8, thus can't be used for Raspbian, still using QT5.4.

TEST PLAN
  Without this change, gcc issues a warning on the case fall-through in function \
unParkMount.  With this change fall-through is acknlowledged and the warning doesn't \
appear.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__proper_fallthrough_warning_silencing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15137

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">TallFurryMan created this revision.<br />TallFurryMan added \
reviewers: mutlaqja, wreissenberger.<br />TallFurryMan added a project: KDE Edu.<br \
/>TallFurryMan requested review of this revision. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15137">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
changeset silences the gcc warning for the case fall-through.<br /> No idea if this \
will work without warning for msvc, but that doesn&#039;t change much compared to the \
previous state.<br /> C++17 can use \
&quot;&lt;https://phabricator.kde.org/w/fallthrough/&gt;;&quot; to specify an \
execution path that intentionally falls through the following case.<br /> \
Q_FALLTHROUGH was introduced in QT5.8, thus can&#039;t be used for Raspbian, still \
using QT5.4.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Without this \
change, gcc issues a warning on the case fall-through in function unParkMount.<br /> \
With this change fall-through is acknlowledged and the warning doesn&#039;t \
appear.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 \
KStars</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>bugfix__proper_fallthrough_warning_silencing \
(branched from master)</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15137">https://phabricator.kde.org/D15137</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kstars/ekos/scheduler/scheduler.cpp</div></div></div><br \
/><div><strong>To: </strong>TallFurryMan, mutlaqja, wreissenberger<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]