[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    D9942: T7614 Memory games patch
From:       Harry Mecwan <noreply () phabricator ! kde ! org>
Date:       2018-01-27 13:51:40
Message-ID: 20180127135140.1.D09D7DCEAED4D5A8 () phabricator ! kde ! org
[Download RAW message or body]

harrymecwan added a comment.


  Okay so Animtim said that many of the activities have the same problem and he would \
like to take some time to come up with a general solution for this and until then it \
is better to patch it with the rectangular scores for vertical screens.

INLINE COMMENTS

> jjazeix wrote in MemoryCommon.qml:167
> you don't display anything on horizontal mode?

on Horizontal mode i display either "You" or "Score" and the score depending on \
whether it is 2 player or not. on vertical mode it displays only the score.
i have attached the screenshot for that. 
https://cdn.pbrd.co/images/H3bWJlF.png

> jjazeix wrote in MemoryCommon.qml:190
> if the text is longer (because in another language, it has more characters), is the \
> text contained in the rectangle or does it override?

it does not. i'll fix that. :)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9942

To: harrymecwan, #gcompris_improvements, jjazeix, asagtani
Cc: #kde_edu, narvaez, apol


[Attachment #3 (unknown)]

<table><tr><td style="">harrymecwan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9942" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Okay so Animtim said that many of the \
activities have the same problem and he would like to take some time to come up with \
a general solution for this and until then it is better to patch it with the \
rectangular scores for vertical screens.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9942#inline-45456" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">MemoryCommon.qml:167</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">you don&#039;t display anything on horizontal mode?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">on \
Horizontal mode i display either &quot;You&quot; or &quot;Score&quot; and the score \
depending on whether it is 2 player or not.<br /> on vertical mode it displays only \
the score.<br /> i have attached the screenshot for that. <br />
<a href="https://cdn.pbrd.co/images/H3bWJlF.png" class="remarkup-link" \
target="_blank" rel="noreferrer">https://cdn.pbrd.co/images/H3bWJlF.png</a></p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9942#inline-45454" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">MemoryCommon.qml:190</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">if the text is longer (because in another language, it has more \
characters), is the text contained in the rectangle or does it \
override?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">it does not. i&#039;ll fix that. \
:)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9942" \
rel="noreferrer">https://phabricator.kde.org/D9942</a></div></div><br \
/><div><strong>To: </strong>harrymecwan, GCompris: Improvements, jjazeix, asagtani<br \
/><strong>Cc: </strong>KDE Edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic