[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 128975: Fix faulty assignment and equal to operator of KEduVocText
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-09-21 20:10:43
Message-ID: 20160921201043.26270.76678 () mimi ! kde ! org
[Download RAW message or body]
--===============0855076334582570127==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128975/#review99394
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Sept. 21, 2016, 6:47 a.m., Hartmut Riesenbeck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128975/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 6:47 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> The two members m_preGrade and m_interval were not copied by the
> assignment operator nor were compared by the equal to operator of the
> KEduVocText class.
>
>
> Diffs
> -----
>
> keduvocdocument/autotests/CMakeLists.txt 679a5f6da25e24fcb064bb612dd0f9d783284e37
> keduvocdocument/autotests/keduvoctexttest.h PRE-CREATION
> keduvocdocument/autotests/keduvoctexttest.cpp PRE-CREATION
> keduvocdocument/keduvoctext.h 7a7408a5ec264af750faf106ac24a31df274d426
> keduvocdocument/keduvoctext.cpp 6205106718efb59140037b1513f149a9ecc4fa2f
>
> Diff: https://git.reviewboard.kde.org/r/128975/diff/
>
>
> Testing
> -------
>
> Test methods to check correct behaviour were added to autotests.
>
>
> Thanks,
>
> Hartmut Riesenbeck
>
>
--===============0855076334582570127==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128975/">https://git.reviewboard.kde.org/r/128975/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On September 21st, 2016, 6:47 a.m. MDT, Hartmut Riesenbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2016, 6:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The two members m_preGrade and m_interval were not \
copied by the assignment operator nor were compared by the equal to operator of the
KEduVocText class.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Test methods to check correct behaviour were added to \
autotests.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/autotests/CMakeLists.txt <span style="color: \
grey">(679a5f6da25e24fcb064bb612dd0f9d783284e37)</span></li>
<li>keduvocdocument/autotests/keduvoctexttest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/autotests/keduvoctexttest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoctext.h <span style="color: \
grey">(7a7408a5ec264af750faf106ac24a31df274d426)</span></li>
<li>keduvocdocument/keduvoctext.cpp <span style="color: \
grey">(6205106718efb59140037b1513f149a9ecc4fa2f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128975/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0855076334582570127==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic