[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 128212: libkeduvocdocument: Non const references methods in KEduVocTranslation ar
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-06-16 19:00:07
Message-ID: 20160616190007.9803.89936 () mimi ! kde ! org
[Download RAW message or body]
--===============1635564603078541775==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128212/#review96606
-----------------------------------------------------------
Fix the above then ship it.
keduvocdocument/keduvoctranslation.h (line 214)
<https://git.reviewboard.kde.org/r/128212/#comment65278>
I wouldn't put "Bad, only compatibility." Please change to "This method is \
deprecated, please use @see foo"
keduvocdocument/keduvoctranslation.h (line 227)
<https://git.reviewboard.kde.org/r/128212/#comment65277>
probably want to name the variable choices like the @param comment says :)
- Jeremy Whiting
On June 16, 2016, 8:52 a.m., Hartmut Riesenbeck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128212/
> -----------------------------------------------------------
>
> (Updated June 16, 2016, 8:52 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> Two methods which returns non const refereces to private member values
> of KEduVocTranslation have been set as deprecated. Alternative
> getter/setter methods were added. The usage of the deprecated methods
> in the library were refactored to new methods.
>
>
> Diffs
> -----
>
> keduvocdocument/keduvockvtml2writer.cpp 682095503680ddf4fd2f1dfe3de8e94fc28fc69d
> keduvocdocument/keduvoctranslation.h 2b72d7a516352ed6f1418d0b9d7a0ac56f511e42
> keduvocdocument/keduvoctranslation.cpp c098060fe98679edd5f45cd451657d378d08cdd9
> keduvocdocument/readerwriters/keduvockvtml2reader.cpp \
> 0bcb4bde0b3455f171002294aad4488abb175543 \
> keduvocdocument/readerwriters/keduvockvtmlreader.cpp \
> 063ac7e2eba447334ea7ead7ba4ed17b3f361de8
> Diff: https://git.reviewboard.kde.org/r/128212/diff/
>
>
> Testing
> -------
>
> Unit tests passed.
>
>
> Thanks,
>
> Hartmut Riesenbeck
>
>
--===============1635564603078541775==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128212/">https://git.reviewboard.kde.org/r/128212/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix \
the above then ship it.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128212/diff/1/?file=469034#file469034line214" \
style="color: black; font-weight: bold; text-decoration: \
underline;">keduvocdocument/keduvoctranslation.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">206</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> \
*/</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">214</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "><span class="cm"> * Bad, only compatibility. Deprecated.</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
wouldn't put "Bad, only compatibility." Please change to "This method is deprecated, \
please use @see foo"</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128212/diff/1/?file=469034#file469034line227" \
style="color: black; font-weight: bold; text-decoration: \
underline;">keduvocdocument/keduvoctranslation.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">212</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span \
class="hl">// </span> void setMultipleChoice( const QStringList &<span \
class="hl">mc </span>);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">227</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span \
class="nf">setMultipleChoice</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QStringList</span> <span \
class="o">&</span><span class="n">coices</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">probably want to name the variable choices like the @param comment says \
:)</p></pre> </div>
</div>
<br />
<p>- Jeremy Whiting</p>
<br />
<p>On June 16th, 2016, 8:52 a.m. MDT, Hartmut Riesenbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated June 16, 2016, 8:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Two methods which returns non const refereces to private member values \
of KEduVocTranslation have been set as deprecated. Alternative getter/setter methods \
were added. The usage of the deprecated methods in the library were refactored to new \
methods.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit tests passed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/keduvockvtml2writer.cpp <span style="color: \
grey">(682095503680ddf4fd2f1dfe3de8e94fc28fc69d)</span></li>
<li>keduvocdocument/keduvoctranslation.h <span style="color: \
grey">(2b72d7a516352ed6f1418d0b9d7a0ac56f511e42)</span></li>
<li>keduvocdocument/keduvoctranslation.cpp <span style="color: \
grey">(c098060fe98679edd5f45cd451657d378d08cdd9)</span></li>
<li>keduvocdocument/readerwriters/keduvockvtml2reader.cpp <span style="color: \
grey">(0bcb4bde0b3455f171002294aad4488abb175543)</span></li>
<li>keduvocdocument/readerwriters/keduvockvtmlreader.cpp <span style="color: \
grey">(063ac7e2eba447334ea7ead7ba4ed17b3f361de8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128212/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1635564603078541775==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic