'Re: Review Request 127354: improve drawing precision for circles'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 127354: improve drawing precision for circles
From:       Maurizio Paolini <paolini () dmf ! unicatt ! it>
Date:       2016-03-22 22:36:04
Message-ID: 20160322223604.21226.29351 () mimi ! kde ! org
[Download RAW message or body]

--===============8588976990153640915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127354/
-----------------------------------------------------------

(Updated March 22, 2016, 10:36 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, David Narváez and Rex Dieter.

Bugs: 359805
    http://bugs.kde.org/show_bug.cgi?id=359805

Repository: kig

Description
-------

QRect object in qt uses integers.  This causes annoying loss of drawing precision \
when drawing circles (https://bugs.kde.org/show_bug.cgi?id=359805).  Using the QRectF \
object seems more appropriate.

Diffs
-----

  misc/kigpainter.h e36c153 
  misc/kigpainter.cpp e547bf2 
  misc/screeninfo.h b7f94c4 
  misc/screeninfo.cc 8fdf115 

Diff: https://git.reviewboard.kde.org/r/127354/diff/

Testing
-------

This is a minimal patch to allow using QRectF when drawing circles.  Perhaps using \
QRect (and QPoint) could be dropped completely in favour of QRectF and QPointF.

File Attachments
----------------

tangent circles - old behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/48f5447f-0904-43ee-8c56-8fc07c03febb__circles_old.png
 tangent circles: new behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/5684b1c5-c32c-447b-bed6-53be380f1b87__circles_new.png
 zoom of old behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/08937b54-e313-4acf-b482-4bd899d24b30__circles_old_zoom.png
 zoom of new behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/e7c0b8fb-af81-43da-b70e-bed3462d73a6__circles_new_zoom.png

Thanks,

Maurizio Paolini

--===============8588976990153640915==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127354/">https://git.reviewboard.kde.org/r/127354/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, David Narváez and Rex Dieter.</div>
<div>By Maurizio Paolini.</div>

<p style="color: grey;"><i>Updated March 22, 2016, 10:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=359805">359805</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QRect object in qt uses integers.  This causes \
annoying loss of drawing precision when drawing circles \
(https://bugs.kde.org/show_bug.cgi?id=359805).  Using the QRectF object seems more \
appropriate.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a minimal patch to allow using QRectF when \
drawing circles.  Perhaps using QRect (and QPoint) could be dropped completely in \
favour of QRectF and QPointF.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>misc/kigpainter.h <span style="color: grey">(e36c153)</span></li>

 <li>misc/kigpainter.cpp <span style="color: grey">(e547bf2)</span></li>

 <li>misc/screeninfo.h <span style="color: grey">(b7f94c4)</span></li>

 <li>misc/screeninfo.cc <span style="color: grey">(8fdf115)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127354/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/48f5447f-0904-43ee-8c56-8fc07c03febb__circles_old.png">tangent \
circles - old behaviour</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/5684b1c5-c32c-447b-bed6-53be380f1b87__circles_new.png">tangent \
circles: new behaviour</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/08937b54-e313-4acf-b482-4bd899d24b30__circles_old_zoom.png">zoom \
of old behaviour</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/e7c0b8fb-af81-43da-b70e-bed3462d73a6__circles_new_zoom.png">zoom \
of new behaviour</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8588976990153640915==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 