[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 125985: Fix build based on the changes for ECMQmLoader in ExtraCmakeModules
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-08 19:28:20
Message-ID: 20151108192820.24343.37504 () mimi ! kde ! org
[Download RAW message or body]
--===============2497112102555165810==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 7, 2015, 2:02 p.m., Albert Astals Cid wrote:
> > This looks wrong, isn't this a mistake in ecm by doing a source incompatible \
> > change?
>
> Alex Merry wrote:
> Only in the sense that if you used the macro incorrectly before, it happened to \
> work by fluke. Using the function from a different CMakeLists.txt file to the \
> target it was being added to was never supposed to work. Neither was using a single \
> call to the function for multiple targets (which I've seen in other projects). The \
> function is patterned after things like the D-Bus interface generation macros, \
> which will also not work if you try to use them like this. It just happened to work \
> with the old implementation.
That said, I suppose e-c-m shouldn't even break that, especially given that several \
projects *have* used it in this way.
I'll revert the change for the version of e-c-m about to be released, and change the \
approach.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125985/#review88139
-----------------------------------------------------------
On Nov. 7, 2015, 1:22 p.m., Raymond Wooninck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125985/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 1:22 p.m.)
>
>
> Review request for KDE Edu and Alex Merry.
>
>
> Repository: analitza
>
>
> Description
> -------
>
> Adjust the CMake files to build successfully after the changes to ECMQmLoader. The \
> fix is based on a similar fix from Alex, that he did for kconfig
>
> Diffs
> -----
>
> analitza/CMakeLists.txt 4894397
> CMakeLists.txt c79b00d
>
> Diff: https://git.reviewboard.kde.org/r/125985/diff/
>
>
> Testing
> -------
>
> Build succesfully
>
>
> Thanks,
>
> Raymond Wooninck
>
>
--===============2497112102555165810==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125985/">https://git.reviewboard.kde.org/r/125985/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 7th, 2015, 2:02 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This looks wrong, isn't this a mistake in ecm by doing \
a source incompatible change?</p></pre> </blockquote>
<p>On November 8th, 2015, 6:03 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only \
in the sense that if you used the macro incorrectly before, it happened to work by \
fluke. Using the function from a different CMakeLists.txt file to the target it was \
being added to was never supposed to work. Neither was using a single call to the \
function for multiple targets (which I've seen in other projects). The function is \
patterned after things like the D-Bus interface generation macros, which will also \
not work if you try to use them like this. It just happened to work with the old \
implementation.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
said, I suppose e-c-m shouldn't even break that, especially given that several \
projects <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">have</em> used it in this way.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll \
revert the change for the version of e-c-m about to be released, and change the \
approach.</p></pre> <br />
<p>- Alex</p>
<br />
<p>On November 7th, 2015, 1:22 p.m. UTC, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Alex Merry.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2015, 1:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adjust the CMake files to build successfully after the \
changes to ECMQmLoader. The fix is based on a similar fix from Alex, that he did for \
kconfig</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build succesfully</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitza/CMakeLists.txt <span style="color: grey">(4894397)</span></li>
<li>CMakeLists.txt <span style="color: grey">(c79b00d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125985/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2497112102555165810==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic