[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 125406: Restore configure dialog, remove command line warnings
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-09-26 23:37:55
Message-ID: 20150926233755.14939.98730 () mimi ! kde ! org
[Download RAW message or body]
--===============8303408040168961876==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125406/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 11:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu and Andrius Å tikonas.
Changes
-------
Submitted with commit 2626de747f683f707478baa3a85c274295bf5ddc by Luigi Toscano to \
branch Applications/15.08.
Bugs: 349984
http://bugs.kde.org/show_bug.cgi?id=349984
Repository: kbruch
Description
-------
This review is for two small changes, partially related:
---
Remove warning about setXMLFile
::createGUI complains that setXMLFile is called, and then createGUI or
setupGUI. According the documentation, if createGUI is manually called,
the "Create" flag should be removed from the setupGUI call.
---
Restore slot definition
Otherwise at least old type connection (like KStandardActions)
do not work and a warning is printed.
BUG: 349984
---
Diffs
-----
src/FractionRingWidget.h 3be8857
src/FractionRingWidget.cpp 69a3d6e
src/MainQtWidget.h 7852733
Diff: https://git.reviewboard.kde.org/r/125406/diff/
Testing
-------
Less messages on the command line; configure dialog can be accessed.
Thanks,
Luigi Toscano
--===============8303408040168961876==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125406/">https://git.reviewboard.kde.org/r/125406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Andrius Å tikonas.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2015, 11:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2626de747f683f707478baa3a85c274295bf5ddc by Luigi \
Toscano to branch Applications/15.08.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=349984">349984</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kbruch
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review is for two small changes, partially related:
---
Remove warning about setXMLFile
::createGUI complains that setXMLFile is called, and then createGUI or
setupGUI. According the documentation, if createGUI is manually called,
the "Create" flag should be removed from the setupGUI call.
---
Restore slot definition
Otherwise at least old type connection (like KStandardActions)
do not work and a warning is printed.
BUG: 349984
---</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Less messages on the command line; configure dialog \
can be accessed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/FractionRingWidget.h <span style="color: grey">(3be8857)</span></li>
<li>src/FractionRingWidget.cpp <span style="color: grey">(69a3d6e)</span></li>
<li>src/MainQtWidget.h <span style="color: grey">(7852733)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8303408040168961876==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic